Skip to content

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Dec 7, 2022

Adds a test to verify the console output of flutter run --release on Windows.

Part of: #111577

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 7, 2022
@loic-sharma loic-sharma marked this pull request as ready for review December 7, 2022 03:54
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma merged commit bebea0c into flutter:master Dec 8, 2022
@loic-sharma loic-sharma deleted the windows_run_test branch December 8, 2022 22:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 15, 2022
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 15, 2022
* 003608f Update text field input width when there are prefix/suffix icons (flutter/flutter#116690)

* bebea0c [Windows] Add a `flutter run` console output test (flutter/flutter#116626)

* 117a83a Throw error when plural case had undefined behavior (flutter/flutter#116622)

* afdc484 add test of flutter update-packages --transitive-closure --consumer-only (flutter/flutter#116747)

* 7c8e171 Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 (flutter/flutter#116635)

* eefbe85 Bump dartdoc to 6.1.4 (flutter/flutter#116758)

* 48cfe2e Opt dashing_postprocess.dart out of null safety until we figure out why (flutter/flutter#116786)

* b4304da Update the Dart language version in the pubspec generated by the dartdoc script (flutter/flutter#116789)

* 55e7501 Roll Plugins from 51434ec to 6ab7d71 (3 revisions) (flutter/flutter#116781)

* e57b7f4 Add Material 3 support for `ListTile` - Part 1 (flutter/flutter#116194)

* 73cb7c2 Squashed MediaQuery InheritedModel (flutter/flutter#114459)

* 1da8f4e Several fixes to packaging builders. (flutter/flutter#116800)

* 86fa9e5 Roll Flutter Engine from 8d83b98c55b3 to 030950f3070c (29 revisions) (flutter/flutter#116802)

* ca3ce39 89fd33c62 Don't use sync*, as it is unimplemented in dart2wasm. (flutter/engine#38149) (flutter/flutter#116808)

* 332032d Roll Flutter Engine from 89fd33c62f2c to a259613ab871 (2 revisions) (flutter/flutter#116811)

* 9dd3087 Add LookupBoundary to Material (flutter/flutter#116736)

* cbdc763 Roll Flutter Engine from a259613ab871 to 8b56b5a98ed4 (2 revisions) (flutter/flutter#116813)

* c4b8046 Floating cursor cleanup (flutter/flutter#116746)

* 7d7848a d64a5129a [const_finder] Ignore constructor invocations from generated tear-off declarations (flutter/engine#38131) (flutter/flutter#116814)

* be5c389 faae28965 Roll Skia from 44062eff3e25 to 1b194c67700e (2 revisions) (flutter/engine#38166) (flutter/flutter#116817)

* 7549925 Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (flutter/flutter#116839)

* 68f02dd Roll Flutter Engine from faae28965a94 to fbb79e704b0a (6 revisions) (flutter/flutter#116843)

* ec02f3b 656b67796 Roll Dart SDK from 0940b5e6ccd5 to 21f2997a8fc6 (9 revisions) (flutter/engine#38172) (flutter/flutter#116844)

* c02d53f More gracefully handle license loading failures (flutter/flutter#87841)

* 4a15111 0795bccae Roll Skia from 0d482f9fa8b3 to 80d9e679f909 (2 revisions) (flutter/engine#38195) (flutter/flutter#116853)

* 1fc166a 3ca497ebb Roll Skia from 80d9e679f909 to 29791c73ae16 (1 revision) (flutter/engine#38200) (flutter/flutter#116859)

* 9fdb64b Taboo the word "simply" from our API documentation. (flutter/flutter#116061)

* 92aebc9 922546c91 [Impeller] Fix asset names used for the generated entrypoint name can contain invalid identifiers for the target language (flutter/engine#38202) (flutter/flutter#116868)

* 437f6f8 9e37c9883 Roll Skia from 29791c73ae16 to 7bd37737e35d (1 revision) (flutter/engine#38207) (flutter/flutter#116871)

* d19f776 62a5de2ef Roll Skia from 7bd37737e35d to 0cb546781e89 (4 revisions) (flutter/engine#38213) (flutter/flutter#116880)

* bd0791b Pass drone_dimensions as part of the main target. (flutter/flutter#116812)

* d1436d1 Roll Plugins from 6ab7d71 to 0609adb (2 revisions) (flutter/flutter#116891)

* 84ed058 [flutter_tools] Add remap sampler support (flutter/flutter#116861)

* a8c9f9c Fix `NavigationBar` ripple for non-default `NavigationDestinationLabelBehavior` (flutter/flutter#116888)

* 5a229e2 Add LookupBoundary to Overlay (flutter/flutter#116741)

* d19047d [framework] make opacity widget create a repaint boundary (flutter/flutter#116788)

* 882e105 Revert "Add Material 3 support for `ListTile` - Part 1 (#116194)" (flutter/flutter#116908)

* 7a743c8 [flutter_tools] Pin and roll pub (flutter/flutter#116745)

* 558b7e0 Adjust test to tolerate additional trace fields (flutter/flutter#116914)

* c420562 Fix output match (flutter/flutter#116912)

* 8e1f835 Fix MediaQuery.paddingOf (flutter/flutter#116858)

* 8cfc606 Roll Flutter Engine from 62a5de2efc9c to 2148fc003077 (5 revisions) (flutter/flutter#116920)

* 601f48c InteractiveViewer discrete trackpad panning (flutter/flutter#112171)

* 41625b6 Test flutter run does not have unexpected engine logs (flutter/flutter#116798)

* 9b46f2a ff2fe8381 [cpp20] Fix incompatible aggregate initialization (flutter/engine#38165) (flutter/flutter#116927)

* 15939b4 Remove duped fix rules (flutter/flutter#116933)

* e331dcd [framework] make transform with filterQuality a rpb (flutter/flutter#116792)

* 6432fd1 6c190ea1e Roll Skia from bb9378b61c4f to 788fe69e7ade (6 revisions) (flutter/engine#38226) (flutter/flutter#116935)

* 97df2b3 Fix scroll jump when NestedScrollPosition is inertia-cancelled. (flutter/flutter#116689)

* ca7fe33 Roll Flutter Engine from 6c190ea1e8df to e144f81e92d8 (3 revisions) (flutter/flutter#116939)

* b713edc 290f3a35e Roll Skia from 788fe69e7ade to 2e417d4f7993 (3 revisions) (flutter/engine#38235) (flutter/flutter#116941)

* 04ee592 Remove RenderEditable textPainter height hack (flutter/flutter#113301)

* 7211ca0 a33e699de Roll Skia from 2e417d4f7993 to 08dc0c9e4e70 (1 revision) (flutter/engine#38239) (flutter/flutter#116952)

* f5249bc Remove use of NullThrownError (flutter/flutter#116122)

* 9ccfb87 64a661d6d Roll Skia from 08dc0c9e4e70 to 9abf4b1bf242 (4 revisions) (flutter/engine#38240) (flutter/flutter#116955)

* 256d54e 47417ce80 [Impeller Scene] Node deserialization (flutter/engine#38190) (flutter/flutter#116959)

* db26f48 afc2f9559 Roll Skia from 9abf4b1bf242 to c83eef7dc2a3 (3 revisions) (flutter/engine#38243) (flutter/flutter#116970)

* 15af817 74a9c7e0f Roll Fuchsia Mac SDK from aMW0DjntzFJj4RoR3... to Cd_ZtrDVcpQ85HRL3... (flutter/engine#38242) (flutter/flutter#116973)

* dbb9aa8 Roll Plugins from 0609adb to ec2041f (6 revisions) (flutter/flutter#116996)

* cd9a439 Roll Flutter Engine from 74a9c7e0f9b1 to 9872cc7addce (2 revisions) (flutter/flutter#116997)

* 4e13720 dd1dc7258 Always set orientation preferences on iOS 16+ (flutter/engine#38230) (flutter/flutter#117005)

* 51945a0 Roll Flutter Engine from dd1dc7258b99 to 82dafdfc1c3d (2 revisions) (flutter/flutter#117015)

* 96597c2 Bump Dartdoc version to 6.1.5 (flutter/flutter#117014)

* 0c7d84a Add AppBar.forceMaterialTransparency (#101248) (flutter/flutter#116867)

* a59dd83 a327b48ca Roll Skia from 280ac8882cff to 537e1e8c1ca6 (9 revisions) (flutter/engine#38264) (flutter/flutter#117025)

* fae458b Convert TimePicker to Material 3 (flutter/flutter#116396)

* ba917d6 Remove workaround because issue is closed (flutter/flutter#110854)

* 60635be 984ec305a Run Mac Host clang-tidy on 12 cores (flutter/engine#38261) (flutter/flutter#117028)

* f0ea376 Roll Flutter Engine from 984ec305a0dd to 14194c40ec00 (2 revisions) (flutter/flutter#117031)

* f07db40 `NavigationBar` improvements (flutter/flutter#116992)

* 028c6e2 [Android] Fix the `run_debug_test_android` device lab test (flutter/flutter#117016)

* 8e452be Marks Windows run_release_test_windows to be unflaky (flutter/flutter#117071)

* 0e0f29f Run packaging builders only on beta and stable. (flutter/flutter#117037)

* ef3fe6a 10c0293 [local_auth]: Bump fragment from 1.5.4 to 1.5.5 in /packages/local_auth/local_auth_android/android (flutter/plugins#6826) (flutter/flutter#117078)

* 7a801f7 0baa4b5b3 Generate font fallback data to be const. (flutter/engine#38259) (flutter/flutter#117080)

* c63d797 Upgrade dependencies (flutter/flutter#117007)

* 57fb36e [reland] Add Material 3 support for `ListTile` - Part 1 (flutter/flutter#116963)

* f9acb1e -- unnecessary parens (flutter/flutter#117081)

* aa0b681 flutter/engine@0baa4b5...0a6a4a58 (flutter/flutter#117083)

* d8b7eb6 Updated token templates to sync with master code. (flutter/flutter#117097)

* 7b19b4d Fix CupertinoTextSelectionToolbar showing unnecessary pagination (flutter/flutter#104587)

* dbc9306 Failure to construct ErrorWidget for build errors does not destroy tree (flutter/flutter#117090)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
Adds a test to verify the console output of `flutter run --release` on Windows.

Part of: flutter#111577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants