Skip to content

[ThemeData 🧹] Deprecate grab-bag properties #116369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guidezpl wants to merge 4 commits into from
Closed

[ThemeData 🧹] Deprecate grab-bag properties #116369

guidezpl wants to merge 4 commits into from

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Dec 1, 2022 •
edited
Loading

Deprecates 11 grab-bag properties whose usages were removed in:

Dart fixes are provided for all deprecations. For the sanity of reviewers, please review theme_data.dart and theme_data.dart.expect to evaluate the fixes, rather than fix_theme_data.yaml.

Part of #91772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Dec 1, 2022
@guidezpl guidezpl changed the title [ThemeData 🧹] Deprecate grab-bag properties [ThemeData 🧹] Deprecate grab-bag properties Dec 1, 2022
This was referenced Jan 16, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@guidezpl
Copy link
Member Author

guidezpl commented Jun 7, 2023

Not planning to do this work at the moment as this requires a lot of internal cleanup and higher priority work has come up. Can always reopen down the line.

@guidezpl guidezpl closed this Jun 7, 2023
@TahaTesser TahaTesser mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guidezpl