[framework] let ImageFiltered and Transform with FilterQuality act as repaint boundaries. #116229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
* [tools]build ipa validate icon size * add more checks in case apple change the format, and also add device lab tests * do not depend on collection package
flutter#115889) * normalize windows file path cases in flutter validator * fix * make comparison more accurate by checking .startsWith() rather than .contains() * fix method name * call path.canonicalize * fix
* Adjust textfield padding * lint * lint
flutter#116234) * Updated `useMaterial3` documentation to include missing M3 components. * Fixed typo
…lutter#116243) * 782d3a600 Roll Skia from 6d759de2e5b2 to 24207007711b (3 revisions) (flutter/engine#37968) * e20362343 [Web, keyboard] Locale layout mapping (flutter/engine#34625)
…lutter#116244) * 8e5192de0 Roll Skia from 24207007711b to 8f4f340f830c (1 revision) (flutter/engine#37970) * d5690468d Roll Dart SDK from 962cd6e0d20a to 88473a3b63ff (13 revisions) (flutter/engine#37969)
…lutter#116290) * 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973) * 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974) * 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977) * 13f136efb [deps] Add `package:intl` (flutter/engine#37980) * 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
* Add Material 3 support for `TabBar` * M3 `TabBar` revert fix and tests
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
commented
Nov 30, 2022
Comment on lines
-2633
to
-2635
| final Matrix4 effectiveTransform = Matrix4.translationValues(offset.dx, offset.dy, 0.0) | ||
| ..multiply(transform)..translate(-offset.dx, -offset.dy); | ||
| final ui.ImageFilter filter = ui.ImageFilter.matrix( |
Contributor
Author
There was a problem hiding this comment.
@flar FYI. I think it is correct to change this code so that the offset flows directly to the ImageFilterLayer and the transform does not take this into account.
Contributor
Author
There was a problem hiding this comment.
The goldens seem different but my read of that issue with the rotation + offset in an image filter layer was that it was the transform render object that was incorrect
Contributor
Author
There was a problem hiding this comment.
I'm not so sure about this, I think it can probably be removed from this PR if it is incorrect
This reverts commit 1cb16a1.
…#116356) * e911e0564 b8f7f1f [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (flutter#115856) (flutter/plugins#6751) * bdf1a98a1 Roll Flutter from 0eb2d51 to cb23473 (13 revisions) (flutter/plugins#6755) * 614d7c0df Roll Flutter from cb23473 to ff59250 (3 revisions) (flutter/plugins#6757) * 2be1da958 Roll Flutter from ff59250 to 17c1dbc (31 revisions) (flutter/plugins#6764) * 381541628 [in_app_purchase_storekit] Add support for macOS (flutter/plugins#6517) * eb796fe2e Roll Flutter from 17c1dbc to b2672fe (26 revisions) (flutter/plugins#6766) * 89ad5a9d6 enable test (flutter/plugins#5312)
* Suggest Rosetta when x64 binary cannot be run * validator * Adjust error message
…output (flutter#115801) * Removes retries from "pub get" and proxies its stdout output * Fix issue where ErrorHandlingProcessManager does not forward "mode" parameter to backing ProcessManager's "start" method * Make "pub get" use ProcessStartMode.inheritStdio instead of forwarding bytes to stdout and stderr * Fix tests * Remove unused env var * Add back 'Running "flutter pub get"...' status log * Fix indent * Add Pub.test() constructor which lets tests mock stdio
…nstead of font metrics (flutter/engine#37998) (flutter#116372)
* [gen_l10n] keys can contain dollar sign Fixes flutter#112250 * Update packages/flutter_tools/lib/src/localizations/gen_l10n.dart Co-authored-by: Christopher Fujino <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.32 to 2.1.35. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4238421...b2a92eb) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…utter into make_image_filtered_rpb
Contributor
Author
|
oops! |
Contributor
Author
|
I investigated the golden diffs a bit and found the difference was due to the behavior of transform and not ImageFiltered. Splitting out the ImageFiltered change to a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #101990
Since ImageFilter layer is an offset layer, we can make the render objects that use these condtionally repaint boundaries. This should improve the performance of the animated image filtered benchmark