Roll engine to f0d440bec3ed79f01890e956b07b6e8e6182db62 #11553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Looks like this roll may have regressed microbenchmarks stock_layout_iteration by about 2x. Only one data point so far, so let's keep watching to see if it was a flake. |
Contributor
|
Also hot reload. |
Contributor
|
This included flutter/engine#3959 which I suspect is the cause of the performance regressions. |
Contributor
|
Filed dart-lang/sdk#30388 to track regressions. |
Contributor
|
This improved the memory benchmarks, but the improvement later regressed, see dart-lang/sdk#30432. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.