-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Re-enable engine dependency proxy test. #115511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: restore the format changes. Same for below changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the ones that were pure formatting ad were correct. There were many places were indentation was wrong and it actually fixed.
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit.
|
auto label is removed for flutter/flutter, pr: 115511, due to - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This is the last step to re-enable tests that were previously disabled and forgotten. This PR also deletes the attache_fuchsia_test.
Bug: #86802
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.