Skip to content

Add inputFormatters in date picker dialog - #115144

Closed
Pana-g wants to merge 4 commits into
flutter:masterfrom
Pana-g:add-inputFormatters-date-picker-form-field
Closed

Add inputFormatters in date picker dialog#115144
Pana-g wants to merge 4 commits into
flutter:masterfrom
Pana-g:add-inputFormatters-date-picker-form-field

Conversation

@Pana-g

@Pana-g Pana-g commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown

Add inputFormatters in showDatePicker function to give users better customizability over the InputDatePickerFormField.

Issues: #115151

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Nov 11, 2022
@rubensdemelo

rubensdemelo commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

any update ?

@HansMuller
HansMuller requested review from HansMuller and removed request for darrenaustin February 24, 2023 23:40
dnfield
dnfield reviewed May 10, 2023
View reviewed changes
Comment thread packages/flutter/test/material/date_picker_test.dart Outdated

@dnfield dnfield May 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either also assert that when inputFormatters is null the length is zero or (better) assert that the input formatters match the list of what was provided.

justinmc
justinmc reviewed May 10, 2023
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me to pipe inputFormatters through to the TextFormField, though I don't have much context on date pickers.

@HansMuller

HansMuller commented May 10, 2023

Copy link
Copy Markdown
Contributor

My apologies, this one got away from us. I agree with @justinmc - this seems like a sensible bit of additional date picker plumbing. If you're still interested in landing this, an API doc example that demo'd using a custom input formatter would make the use case easier for other developers to understand.

@Pana-g
Pana-g force-pushed the add-inputFormatters-date-picker-form-field branch from ce7ecf8 to f6df7b8 Compare May 11, 2023 14:00
@HansMuller

HansMuller commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Per #115144 (comment):
"an API doc example that demo'd using a custom input formatter would make the use case easier for other developers to understand"

@HansMuller

HansMuller commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

@Pana-g - are you planning to continue working on this PR per #115144 (comment) ?

@Hixie Hixie mentioned this pull request Oct 31, 2023
Closed
@Hixie

Hixie commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

@Pana-g thanks for your contributions on this! I've added a link to this PR to the issue so that the next person to start working on this can start with your work. I'm going to close this PR for now. Thanks!

@Hixie Hixie closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc left review comments
@HansMuller HansMuller Awaiting requested review from HansMuller
+1 more reviewer
@dnfield dnfield dnfield left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Pana-g @rubensdemelo @HansMuller @Hixie @justinmc @dnfield