Add visual density for menu default style #114878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
QuncCccccc
force-pushed
the
add_visualDensity_for_menu_default_style
branch
from
9d61cbd to
fa0dfc9
Compare
QuncCccccc
force-pushed
the
add_visualDensity_for_menu_default_style
branch
from
d7beb47 to
054b5fa
Compare
gspencergoog
approved these changes
Mar 1, 2023
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
@QuncCccccc I'm so sorry, this fell through the cracks in my review queue!
Contributor
There was a problem hiding this comment.
Suggested change
| // the density is less than zero, such as on the desktop platform. | |
| // the density is less than zero, such as on desktop platforms. |
Contributor
Author
There was a problem hiding this comment.
No worries at all! Thanks for taking time to review. Will rebase master and merge it soon:)!
QuncCccccc
force-pushed
the
add_visualDensity_for_menu_default_style
branch
from
054b5fa to
5afcbdf
Compare
QuncCccccc
force-pushed
the
add_visualDensity_for_menu_default_style
branch
from
cdce008 to
5e22719
Compare
QuncCccccc
commented
Mar 1, 2023
| Rect.fromLTRB(145.0, 0.0, 655.0, 40.0), | ||
| Rect.fromLTRB(257.0, 40.0, 467.0, 176.0), | ||
| Rect.fromLTRB(467.0, 80.0, 715.0, 256.0), | ||
| Rect.fromLTRB(161.0, 0.0, 639.0, 40.0), |
Contributor
Author
There was a problem hiding this comment.
Numbers are updated here because the visual density is compact(-2, -2) here.
| Rect.fromLTRB(145.0, 0.0, 655.0, 40.0), | ||
| Rect.fromLTRB(333.0, 40.0, 543.0, 176.0), | ||
| Rect.fromLTRB(85.0, 80.0, 333.0, 256.0), | ||
| Rect.fromLTRB(161.0, 0.0, 639.0, 40.0), |
QuncCccccc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
QuncCccccc
added a commit
that referenced
this pull request
Mar 2, 2023
This reverts commit 37be384.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
QuncCccccc
added a commit
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
QuncCccccc
added a commit
that referenced
this pull request
Mar 3, 2023
QuncCccccc
added a commit
that referenced
this pull request
Mar 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #114850
This PR is to fix the issue that the Menu doesn't respond to density changes when the visual density is less than zero. When the app is running on the desktop platform, the menu should look denser based on its
VisualDensitywhich is -2. I set the minimum horizontal padding to 8 px to make sure the padding will never go to zero.VisualDensity: 0 (standard)
VisualDensity: -2 (compact)
Pre-launch Checklist
///).