Do not assume that pub is the first command run by "flutter create" #114621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
zanderso
reviewed
Nov 3, 2022
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
The two expect checks for each create call are no longer guaranteed to apply to the same command. Better would be to collapse the two expects into a single one that uses a predicate matcher: https://api.flutter.dev/flutter/package-matcher_matcher/predicate.html
Member
There was a problem hiding this comment.
Should this be everyElement(isNot(contains(...)))?
jason-simmons
force-pushed
the
fix_create_openssl_test
branch
from
ab9484f to
fe6e4ff
Compare
Member
Author
|
Updated the test - PTAL |
zanderso
approved these changes
Nov 3, 2022
GaryQian
reviewed
Nov 3, 2022
Contributor
There was a problem hiding this comment.
nit analyzer expects this to be final
GaryQian
approved these changes
Nov 3, 2022
Contributor
GaryQian
left a comment
GaryQian
left a comment
There was a problem hiding this comment.
Analyzer needs to be fixed
jmagman
approved these changes
Nov 3, 2022
The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam
jason-simmons
force-pushed
the
fix_create_openssl_test
branch
from
fe6e4ff to
2947690
Compare
cbracken
approved these changes
Nov 3, 2022
8 tasks
This was referenced Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 4, 2022
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Nov 4, 2022
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
Nov 9, 2022
…lutter#114621) The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam
CaseyHillers
pushed a commit
that referenced
this pull request
Nov 9, 2022
… create" (#114621) (#114945) The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam Co-authored-by: Jason Simmons <[email protected]>
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114621) The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam