Revert "Always evaluate the finder in driver.waitFor*()"
#11451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yjbanov |
Contributor
|
LGTM. Wondering why GitHub is showing that you are reverting 9 commits. |
Contributor
Author
|
Weirdly they're all empty... |
Contributor
Author
|
I'll land this on green after I've rolled internally. |
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11434
This patch landed around the same time as we changed devices, and it had an odd impact on the numbers, mostly making them much less noisy. I think this makes sense given the fix, but I'm curious to see if removing this patch also reverts the change, or if it's actually all about the hardware change. I suspect it may be all hardware since little changed on iOS over the same time period.