Tiny improvement of RouteSettings display #114481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: routes
chunhtai
approved these changes
Nov 17, 2022
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, added a suggestion
chunhtai
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 114481, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 114481, due to Validations Fail. |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 19, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 19, 2022
* 87cb150 InkResponse highlights can be updated (flutter/flutter#115635) * 10c039b ca5b2f31c Roll Skia from d693b4b9fe5e to ab054a88d7c7 (1 revision) (flutter/engine#37743) (flutter/flutter#115654) * 7fd3bb2 Roll Plugins from a2fa4e9 to b2fe01b (6 revisions) (flutter/flutter#115656) * 3a3a0db Disallow dispose during listener callback (flutter/flutter#114530) * ca78327 Fix `NavigationBar` ripple (flutter/flutter#115499) * 4593917 [flutter_tools] Pin package:archive and manual roll (flutter/flutter#115662) * 9807761 Tiny improvement of RouteSettings display (flutter/flutter#114481) * 2cb2e84 Add more InkWell tests (flutter/flutter#115634) * 24865ad Remove unneeded comparison to `double.nan` (flutter/flutter#115547) * d2e6dfe Fix formatting in BottomAppBar test (flutter/flutter#115520) * 22e1ac7 b32c3a307 Roll Skia from ab054a88d7c7 to 345bceacd298 (3 revisions) (flutter/engine#37745) (flutter/flutter#115658) * 01c1e8e Allows pushing page based route as pageless route (flutter/flutter#114362) * 0e57147 nav drawer (flutter/flutter#115668) * cf2c9f6 Remove package:image dependency (flutter/flutter#115674) * 46d868c Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (flutter/flutter#115672) * 0fc4a3e Revert "Remove package:image dependency (#115674)" (flutter/flutter#115680) * c69fbf1 a77dfaff3 Remove `Linux Web Engine` from recipes CQ (flutter/engine#37758) (flutter/flutter#115675) * c95b693 f81ac3b19 Fix glyph sampling overlap (flutter/engine#37764) (flutter/flutter#115683) * be0c3a7 cef11cb9a Roll Skia from 12f01bc5b57e to c53d8cf5b823 (4 revisions) (flutter/engine#37767) (flutter/flutter#115684) * ae18d7b 6da59402e Roll Skia from c53d8cf5b823 to 0c1fcbe97b1f (1 revision) (flutter/engine#37771) (flutter/flutter#115685) * a17b4c3 91bc694eb Roll Fuchsia Mac SDK from tklUfTsSOVKk49tYq... to UcfQiA4PBOCs_7GEK... (flutter/engine#37773) (flutter/flutter#115686) * 1bee357 2d5e0667e Roll Fuchsia Linux SDK from WdtwlLEce90PjFJ9z... to qc20R_3e8PoqMQWgw... (flutter/engine#37775) (flutter/flutter#115687) * 633d7ef 916fd798d Roll Skia from 0c1fcbe97b1f to ad354e712b96 (2 revisions) (flutter/engine#37776) (flutter/flutter#115689)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
* impl * Update packages/flutter/lib/src/widgets/navigator.dart Co-authored-by: chunhtai <[email protected]> * Update navigator_test.dart Co-authored-by: chunhtai <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* impl * Update packages/flutter/lib/src/widgets/navigator.dart Co-authored-by: chunhtai <[email protected]> * Update navigator_test.dart Co-authored-by: chunhtai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When name is null, originally it prints something like:
RouteSettings("null", null). But we know"null"looks like a string instead of a real null. So I change toRouteSettings(null, null)when that is null.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.