add a profile() method #11443
Merged
add a profile() method #11443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jul 28, 2017
| import 'package:flutter/foundation.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| const bool isReleaseMode = const bool.fromEnvironment("dart.vm.product"); |
Contributor
There was a problem hiding this comment.
fwiw, now that i think of this some more: this will always be false. We run all our tests in debug mode always.
Hixie
reviewed
Jul 28, 2017
| }); | ||
| expect(count, isReleaseMode ? 0 : 1); | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
There's really no good way for us to test that profile actually omits the code in release builds in the current infrastructure. At some point we should probably do a real test for this.
Contributor
|
...but add a comment or todo to the test mentioning that the test isn't really testing what matters. :-) |
Contributor
Author
|
Makes sense; added |
Hixie
added a commit
that referenced
this pull request
Aug 1, 2017
* Revert "Make plugins add their repos to projects in the consuming app (#11447)" This reverts commit abe1e25. * Revert "Support for custom build types on Android (#11354)" This reverts commit 87eec71. * Revert "add a profile() method (#11443)" This reverts commit 561d17a. * Revert "Fix documentation based on dartdoc's warnings (#11428)" This reverts commit 6655074. * Revert "Improve some docs around WillPopScope. (#11429)" This reverts commit 58a28a2. * Revert "temporarily disable broken driver test in integration_ui (#11440)" This reverts commit 764515e. * Revert "style fix" This reverts commit 00bfc86. * Revert "tests for waitFor/waitForAbsent" This reverts commit 31d2ee9. * Revert "Always evaluate the finder in `driver.waitFor()` and `driver.waitForAbsent()`" This reverts commit 11d7c79.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
profile()method - it will only execute the given function in debug or profile modes