Always evaluate the finder in driver.waitFor*()
#11434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jul 28, 2017
| try { | ||
| await driver.waitForAbsent(presentText, timeout: const Duration(seconds: 1)); | ||
| fail('expected DriverError'); | ||
| } on DriverError catch(error) { |
Contributor
There was a problem hiding this comment.
nittiest of nits: space after catch before (
Contributor
|
|
Contributor
|
For those looking at performance benchmarks: This patch was the first patch immediately after we changed the test hardware from Nexus 5s to Moto G4s. We later tested removing this patch to see if it affected the numbers and it did not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests on top of @tvolkert's changes from #11329.
Fixes #11327
cc @Hixie for review