Improve some docs around WillPopScope. #11429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HansMuller for review |
...and break the navigator<->routes circular dependency. This is a step towards fixing flutter#9577 but doesn't yet do so.
HansMuller
reviewed
Jul 28, 2017
| /// | ||
| /// If [Route.willPop] returns [pop] then the back button will actually pop | ||
| /// the current route. | ||
| pop, |
Contributor
There was a problem hiding this comment.
Per our conversation, this isn't new code, it's just been relocated. We need to decide/document what it means to pop the last route.
HansMuller
reviewed
Jul 28, 2017
| /// | ||
| /// If [Route.willPop] return [bubble] then the back button will be handled | ||
| /// by the [SystemNavigator], which will usually close the application. | ||
| bubble, |
Contributor
There was a problem hiding this comment.
We need to clarify what this means if there are nested navigators. I would think that we'd want bubble to mean: defer to the parent navigator or the SystemNavigator if there's no parent.
Contributor
|
LGTM |
Hixie
added a commit
that referenced
this pull request
Aug 1, 2017
* Revert "Make plugins add their repos to projects in the consuming app (#11447)" This reverts commit abe1e25. * Revert "Support for custom build types on Android (#11354)" This reverts commit 87eec71. * Revert "add a profile() method (#11443)" This reverts commit 561d17a. * Revert "Fix documentation based on dartdoc's warnings (#11428)" This reverts commit 6655074. * Revert "Improve some docs around WillPopScope. (#11429)" This reverts commit 58a28a2. * Revert "temporarily disable broken driver test in integration_ui (#11440)" This reverts commit 764515e. * Revert "style fix" This reverts commit 00bfc86. * Revert "tests for waitFor/waitForAbsent" This reverts commit 31d2ee9. * Revert "Always evaluate the finder in `driver.waitFor()` and `driver.waitForAbsent()`" This reverts commit 11d7c79.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and break the navigator<->routes circular dependency.
This is a step towards fixing #9577 but doesn't yet do so.