Fix documentation based on dartdoc's warnings #11428
Conversation
dev/tools/dartdoc.dart
Outdated
There was a problem hiding this comment.
fyi @jcollins-g i'm planning on turning on --auto-include-dependencies
There was a problem hiding this comment.
Just so you know, she's OOO through part of next week.
There was a problem hiding this comment.
cc @xster this is the change i was talking about. (part 1/2)
There was a problem hiding this comment.
cc @jacob314 there are a number of changes relating to your recent patch throughout this PR, starting here
There was a problem hiding this comment.
LGTM for all the tree_diagnostics_mixin changes.
Thanks for cleaning this up!
There was a problem hiding this comment.
cc @HansMuller this is the change we talked about earlier
There was a problem hiding this comment.
cc @xster this is the test for the change above. (part 2/2)
There was a problem hiding this comment.
cc @yjbanov this and the next change are to driver's docs
dev/tools/dartdoc.dart
Outdated
There was a problem hiding this comment.
If this is filtering out "parse" and "parsing", then maybe r'^pars(e|ing)'?
There was a problem hiding this comment.
i'm tempted to just remove these two. it was only to make it a little easier while i was going through the output.
|
Yegor was your LGTM for the whole patch or just the driver part? |
There was a problem hiding this comment.
why not middle == null ? null like you did above?
There was a problem hiding this comment.
copypasta. i'll fix it.
There was a problem hiding this comment.
what about just actionsStyle.copyWith so everything except the color is in one place?
|
Ok I think the three LGTMs above cover all the code here so I'm going to land on green. |
LGTM for the driver parts, and somewhat RSLGTM for others. |
* Revert "Make plugins add their repos to projects in the consuming app (#11447)" This reverts commit abe1e25. * Revert "Support for custom build types on Android (#11354)" This reverts commit 87eec71. * Revert "add a profile() method (#11443)" This reverts commit 561d17a. * Revert "Fix documentation based on dartdoc's warnings (#11428)" This reverts commit 6655074. * Revert "Improve some docs around WillPopScope. (#11429)" This reverts commit 58a28a2. * Revert "temporarily disable broken driver test in integration_ui (#11440)" This reverts commit 764515e. * Revert "style fix" This reverts commit 00bfc86. * Revert "tests for waitFor/waitForAbsent" This reverts commit 31d2ee9. * Revert "Always evaluate the finder in `driver.waitFor()` and `driver.waitForAbsent()`" This reverts commit 11d7c79.
6 participants
No description provided.