Add Material 3 support for `Slider` - Part 1 #114079

TahaTesser · 2022-10-26T15:51:12Z

code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      themeMode: ThemeMode.light,
      theme: ThemeData(
        useMaterial3: true,
        brightness: Brightness.light,
        colorSchemeSeed: const Color(0xff6750a4),
      ),
      darkTheme: ThemeData(
        useMaterial3: true,
        brightness: Brightness.dark,
        colorSchemeSeed: const Color(0xff6750a4),
      ),
      home: const SliderExample(),
    );
  }
}

class SliderExample extends StatefulWidget {
  const SliderExample({super.key});

  @override
  State<SliderExample> createState() => _SliderExampleState();
}

class _SliderExampleState extends State<SliderExample> {
  double sliderValue = 20;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Slider'),
      ),
      body: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: <Widget>[
          Slider(
            value: sliderValue,
            max: 100,
            // divisions: 5,
            label: sliderValue.round().toString(),
            onChanged: (double value) {
              setState(() {
                sliderValue = value;
              });
            },
          ),
          Slider(
            value: sliderValue,
            max: 100,
            divisions: 5,
            label: sliderValue.round().toString(),
            onChanged: (double value) {
              setState(() {
                sliderValue = value;
              });
            },
          ),
        ],
      ),
    );
  }
}

Description

(Splitting M3 Slider into 2 parts to make it easy it track changes and review)

This PR adds support Material 3 colors to Slider along with new tests.
(Part 2 will include a new M3 value indicator tokens and shape and thumb)

Added Material 2 and Material 3 defaults in slider.dart.
Added a new "Slider defaults" test for M2 and M3 in slider_theme_test.dart.
(this test checks default track height and colors, it will also check the default value indicator in part 2)
Improved "Slider uses the right theme colors for the right components" in slider_theme_test.dart to check sliderTheme.disabledActiveTickMarkColor & sliderTheme.disabledInactiveTickMarkColor colors.
Updated tests for hover, focus, and dragged and added M3 variants of these tests in slider_test.dart.
Updated docs.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TahaTesser · 2022-10-26T19:11:29Z

~~From Linux web_canvaskit_tests_5:~~

It called drawRRect with a paint whose color, MaterialColor(primary value:
Color(0xff2196f3)), was not exactly the expected color (Color(0xff2196f3)).

MaterialColor based ColorScheme.primary is only expected on the web for some reason.
I cannot see any failure when testing locally.

This is resolved after rebasing again today.

darrenaustin

Looks good. Thx!

Just a few questions and suggestions below.

dev/tools/gen_defaults/lib/slider_template.dart

packages/flutter/lib/src/material/slider.dart

darrenaustin

Nice work. Thx.

dev/tools/gen_defaults/lib/slider_template.dart

darrenaustin · 2022-11-01T07:32:44Z

Looks like there are some internal golden tests failing, but the internal tool isn't showing any results, so I will need to track down what is going on tomorrow. I'll update when I know more.

TahaTesser · 2022-11-01T08:36:25Z

While not critical, this is not showing a change to Colors.transparent, or am I looking at the wrong diff?

Fixed.

I forgot to update the template since gen_defaults was out of sync and I had to revert other changes made when executing dart dev/tools/gen_defaults/bin/gen_defaults.dart but now only bottom_app_bar.dart seems to be out of sync, Filed an issue for it here #114405

…#114079)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

* 4f19a9f [flutter_tools] Add support for compiling shaders to JSON bundle for web (flutter/flutter#114295) * f186e1b Roll pub packages (flutter/flutter#114363) * 0c7ee58 Make `Linux_android android_semantics_integration_test` flaky (flutter/flutter#114361) * 7ab2bf8 Delete flutter_migrate code (flutter/flutter#114253) * 0d26c51 Roll Flutter Engine from e432d6fc3a9b to ef4acbfe67ac (2 revisions) (flutter/flutter#114367) * af44c05 Roll Flutter Engine from ef4acbfe67ac to 9ba3de8f078d (1 revision) (flutter/flutter#114368) * 7979c87 Roll Flutter Engine from 9ba3de8f078d to ef45b5ac5b4b (1 revision) (flutter/flutter#114370) * c1a0846 Roll Flutter Engine from ef45b5ac5b4b to 96c0353790a2 (2 revisions) (flutter/flutter#114372) * a75c1ff Roll Flutter Engine from 96c0353790a2 to 1a8ba7c5521a (1 revision) (flutter/flutter#114375) * b20b7d9 Roll Flutter Engine from 1a8ba7c5521a to c16e2c08724c (1 revision) (flutter/flutter#114379) * 37b7234 Add `maybeOf` for all the cases where `of` returns nullable. (flutter/flutter#114120) * 6edbaa7 Roll Flutter Engine from c16e2c08724c to 034a2da497d9 (2 revisions) (flutter/flutter#114387) * 4851401 Roll Flutter Engine from 034a2da497d9 to f721db653dd1 (1 revision) (flutter/flutter#114389) * c2edb20 Added token files for badges and lists. (flutter/flutter#114382) * 0f1d0e3 🎨 Improve exceptions thrown by asset bundle (flutter/flutter#114313) * 3894a06 Minor code cleanup: remove redundant return (flutter/flutter#114290) * 0e98194 Add Material 3 support for BottomAppBar (flutter/flutter#106525) * 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 26, 2022

TahaTesser requested a review from darrenaustin October 26, 2022 15:51

TahaTesser force-pushed the m3_slider_part_1 branch from 07120c5 to c4051d2 Compare October 26, 2022 17:14

TahaTesser force-pushed the m3_slider_part_1 branch 2 times, most recently from 8b87992 to 74a2a43 Compare October 28, 2022 08:28

darrenaustin suggested changes Oct 28, 2022

View reviewed changes

TahaTesser requested a review from darrenaustin October 31, 2022 11:28

darrenaustin approved these changes Nov 1, 2022

View reviewed changes

dev/tools/gen_defaults/lib/slider_template.dart Outdated Show resolved Hide resolved

dev/tools/gen_defaults/lib/slider_template.dart Outdated Show resolved Hide resolved

TahaTesser force-pushed the m3_slider_part_1 branch from 3bc9b26 to 707016f Compare November 1, 2022 08:31

TahaTesser added 2 commits November 1, 2022 20:13

Add Material 3 support for Slider - Part 1

3387f35

fix analyzer

54a741f

TahaTesser force-pushed the m3_slider_part_1 branch from 3911f43 to 54a741f Compare November 1, 2022 18:14

darrenaustin merged commit 97d0247 into flutter:master Nov 2, 2022

TahaTesser deleted the m3_slider_part_1 branch November 2, 2022 07:36

TahaTesser mentioned this pull request Nov 2, 2022

Update Slider to support Material 3 #111451

Closed

This was referenced Nov 2, 2022

Roll Flutter from 37beffe2a98b to 45c3b028cabb (48 revisions) flutter/packages#2769

Closed

Roll Flutter from 0e98194681fd to 45c3b028cabb (31 revisions) flutter/plugins#6651

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

282b358

…#114079)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

e1d113c

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 37beffe2a98b to 9f2339173320 (49 revisions) flutter/packages#2770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

62ab544

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 9f2339173320 (32 revisions) flutter/plugins#6652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

32c06b1

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 37beffe2a98b to db381d75b195 (50 revisions) flutter/packages#2771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

13677a1

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 1cfdac4b2314 (34 revisions) flutter/plugins#6653

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

8055dae

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 1f7bacff423f (36 revisions) flutter/plugins#6654

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

5c4f34c

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 307987339ede (37 revisions) flutter/plugins#6655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

4db5a4c

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 78dbe6661b35 (38 revisions) flutter/plugins#6658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

8e9783f

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 37beffe2a98b to 92a66683a1ed (62 revisions) flutter/packages#2774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

d5df399

…#114079)

engine-flutter-autoroll mentioned this pull request Nov 3, 2022

Roll Flutter from 0e98194681fd to 92a66683a1ed (45 revisions) flutter/plugins#6663

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

1ff815c

…#114079)

This was referenced Nov 3, 2022

Roll Flutter from 37beffe2a98b to e6300da2c39f (63 revisions) flutter/packages#2776

Merged

Roll Flutter from 0e98194681fd to e6300da2c39f (46 revisions) flutter/plugins#6668

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

03ed5fc

…#114079)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022

97d0247 Add Material 3 support for Slider - Part 1 (flutter/flutter…

e2352bb

…#114079)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Material 3 support for `Slider` - Part 1 #114079

Add Material 3 support for `Slider` - Part 1 #114079

Uh oh!

TahaTesser commented Oct 26, 2022 •

edited

Loading

Uh oh!

TahaTesser commented Oct 26, 2022 •

edited

Loading

Uh oh!

darrenaustin left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darrenaustin left a comment

Uh oh!

Uh oh!

Uh oh!

darrenaustin commented Nov 1, 2022

Uh oh!

TahaTesser commented Nov 1, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add Material 3 support for Slider - Part 1 #114079

Add Material 3 support for Slider - Part 1 #114079

Uh oh!

Conversation

TahaTesser commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-launch Checklist

Uh oh!

TahaTesser commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darrenaustin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darrenaustin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

darrenaustin commented Nov 1, 2022

Uh oh!

TahaTesser commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add Material 3 support for `Slider` - Part 1 #114079

Add Material 3 support for `Slider` - Part 1 #114079

TahaTesser commented Oct 26, 2022 •

edited

Loading

TahaTesser commented Oct 26, 2022 •

edited

Loading

TahaTesser commented Nov 1, 2022 •

edited

Loading