Skip to content

Fix StarBorder operator== #113588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Oct 18, 2022
Merged

Fix StarBorder operator== #113588

auto-submit merged 3 commits into from
Oct 18, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 18, 2022

Description

This fixes the operator== on StarBorder to consider all of the parameters so that it will rebuild when the values change.

Tests

  • Added tests for inequality and type mismatch.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 18, 2022
@gspencergoog gspencergoog force-pushed the fix_star_border branch 3 times, most recently from 62fd179 to 1dda878 Compare October 18, 2022 02:03
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 18, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #113588 at sha 404837c

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 18, 2022
HansMuller
HansMuller approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hixie
Hixie approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 18, 2022

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #113588 at sha 7529c74

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2022
@auto-submit auto-submit bot merged commit 9995e37 into flutter:master Oct 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
9995e37 Fix StarBorder operator== (flutter/flutter#113588)
8cd2f5a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 19, 2022
@engine-flutter-autoroll
9995e37 Fix StarBorder operator== (flutter/flutter#113588)
cda57ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gspencergoog @Hixie @HansMuller