Skip to content

Remove cross_arch_tests from recipes cq. #113569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 18, 2022
Merged

Remove cross_arch_tests from recipes cq. #113569

auto-submit merged 1 commit into from
Oct 18, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Oct 17, 2022

These tests are blocking rolls of the recipe dependencies.

https://ci.chromium.org/p/flutter/builders/try/recipes-with-led/b8800032390708370785?

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested a review from keyonghan as a code owner October 17, 2022 20:42
@godofredoc godofredoc requested a review from jmagman October 17, 2022 20:42
@jmagman
Copy link
Member

jmagman commented Oct 17, 2022 

An error occurred while installing ffi (1.15.5), and Bundler cannot continue.

Hm, why is this needed on master?

https://flutter-review.googlesource.com/c/recipes/+/34400/comments/3de8d3da_334648a4

recipes-with-led isn't configured to correctly run on release branches. It's testing against main configs, so release team unfortunately has to monitor in prod.

@godofredoc
Copy link
Contributor Author

godofredoc commented Oct 17, 2022 

An error occurred while installing ffi (1.15.5), and Bundler cannot continue.

Hm, why is this needed on master?

https://flutter-review.googlesource.com/c/recipes/+/34400/comments/3de8d3da_334648a4

recipes-with-led isn't configured to correctly run on release branches. It's testing against main configs, so release team unfortunately has to monitor in prod.

Mac_arm64 tool_host_cross_arch_tests is failing consistently and should not be blocking recipes CLs. Maybe we need a test that fails if we set bringup: true with enable_cq: true?

If Mac_x64 tool_host_cross_arch_tests should be blocking recipe CLs I can update this change to only remove CQ from the arm64 and try to find the error.

@jmagman
Copy link
Member

jmagman commented Oct 18, 2022

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.

I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

@godofredoc
Copy link
Contributor Author

godofredoc commented Oct 18, 2022

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.

I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.

I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.

I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

There is something very strange with this test, led is not collecting $flutter/osx_sdk property. Can we land this change as it is and bring the tests to recipes cq once the test is fixed? They are failing in different fronts and they are blocking multiple fixes to recipes.

ricardoamador
ricardoamador approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc
Copy link
Contributor Author

godofredoc commented Oct 18, 2022

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.
I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.
I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

The arm recipe crash is #113231, which is why it has ignore_flakiness: "true" #112999.
I don't understand why x64 has an ffi error though, that should be passing: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/aa5c8a8d8a5420b170861e817546b277f995f17b8c8e86d1ca9a44f5181fb7ab/+/build.proto

There is something very strange with this test, led is not collecting $flutter/osx_sdk property. Can we land this change as it is and bring the tests to recipes cq once the test is fixed? They are failing in different fronts and they are blocking multiple fixes to recipes.

Tracking issue: #113611

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2022
@auto-submit auto-submit bot merged commit 1074048 into flutter:master Oct 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
1074048 Remove cross_arch_tests from recipes cq. (flutter/flutter#113569
bf6c424 
)
@nehalvpatel nehalvpatel mentioned this pull request Oct 18, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 19, 2022
@engine-flutter-autoroll
1074048 Remove cross_arch_tests from recipes cq. (flutter/flutter#113569
7dcd957 
)
@godofredoc godofredoc deleted the remove_arch_cq branch November 9, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

@jmagman jmagman Awaiting requested review from jmagman

@nehalvpatel nehalvpatel Awaiting requested review from nehalvpatel

1 more reviewer

@ricardoamador ricardoamador ricardoamador approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @ricardoamador