Skip to content

[CP] Remove exclamation marks (#107683) #113553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyHillers merged 2 commits into from
Oct 31, 2022
Merged

[CP] Remove exclamation marks (#107683) #113553

CaseyHillers merged 2 commits into from
Oct 31, 2022

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Oct 17, 2022

Cherry picking #107683 in order to fix exceptions reported in issues like #111095.

Fixes #113550

@justinmc justinmc requested a review from itsjustkevin October 17, 2022 17:01
@justinmc justinmc self-assigned this Oct 17, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 17, 2022

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 17, 2022
@itsjustkevin itsjustkevin mentioned this pull request Oct 17, 2022
Closed
@justinmc
Copy link
Contributor Author

justinmc commented Oct 17, 2022

The failures seem to be due to an analyzer failure in image_picker_windows.dart, which is not something that was changed in this PR. Should I fix that here, or what is the protocol for that?

LongCatIsLooong
LongCatIsLooong approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are the tests supposed to be failing?

@justinmc
Copy link
Contributor Author

justinmc commented Oct 18, 2022

Good question, @itsjustkevin do you know if the tests should be passing? The failures seem unrelated with a quick glance.

@absar absar mentioned this pull request Oct 26, 2022
Closed
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Oct 31, 2022

Good question, @itsjustkevin do you know if the tests should be passing? The failures seem unrelated with a quick glance.

These are known failures, I'll merge them in.

@CaseyHillers CaseyHillers merged commit 8536931 into flutter:flutter-3.2-candidate.5 Oct 31, 2022
@justinmc justinmc deleted the flutter-3.2-candidate.5-cp-remove-exclamation branch October 31, 2022 21:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#11…
3c383ac 
…3553)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#11…
30d8072 
…3553)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#11…
bca0b7d 
…3553)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#11…
ddc71f4 
…3553)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter (stable) from 6928314d505d to e99c9c7cd9f6 (2 revisions) (…
dd8245e 
…#6667)

* 85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#113553)

* e99c9c7cd Update Engine revision to 857bd6b74c5eb56151bfafe91e7fa6a82b6fee25 for stable release 3.3.7 (flutter/flutter#114456)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter (stable) from 6928314d505d to e99c9c7cd9f6 (2 revisions) (…
c98567e 
…flutter#6667)

* 85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#113553)

* e99c9c7cd Update Engine revision to 857bd6b74c5eb56151bfafe91e7fa6a82b6fee25 for stable release 3.3.7 (flutter/flutter#114456)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter (stable) from 6928314d505d to e99c9c7cd9f6 (2 revisions) (…
58d5bde 
…flutter#6667)

* 85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#113553)

* e99c9c7cd Update Engine revision to 857bd6b74c5eb56151bfafe91e7fa6a82b6fee25 for stable release 3.3.7 (flutter/flutter#114456)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter (stable) from 6928314d505d to e99c9c7cd9f6 (2 revisions) (…
b622c4d 
…flutter#6667)

* 85369313b [CP] Remove exclamation marks (#107683) (flutter/flutter#113553)

* e99c9c7cd Update Engine revision to 857bd6b74c5eb56151bfafe91e7fa6a82b6fee25 for stable release 3.3.7 (flutter/flutter#114456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

+1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmc @CaseyHillers @LongCatIsLooong