Skip to content

Modal barrier shouldn't paint when the route is offstage. #11347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hixie merged 1 commit into from
Jul 21, 2017
Merged

Modal barrier shouldn't paint when the route is offstage. #11347

Hixie merged 1 commit into from
Jul 21, 2017

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 21, 2017

Fixes #11323

goderbauer
goderbauer approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie merged commit dd40d0e into flutter:master Jul 21, 2017
@Hixie Hixie deleted the modalBarrier branch July 21, 2017 23:39
goderbauer added a commit that referenced this pull request Jul 24, 2017
@goderbauer
Revert "Modal barrier shouldn't paint when the route is offstage. (#1…
9a9433f 
…1347)"

This reverts commit dd40d0e.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modal barrier on AlertDialog doesn't animate in smoothly

3 participants

@Hixie @goderbauer @googlebot