AnimatedCrossFade layout customisation #11343
Conversation
There was a problem hiding this comment.
Should we also _controller.stop()?
There was a problem hiding this comment.
merged these two blocks together and just made the layout use elvis:
if (child == null || constraints.isTight) {
_controller.stop();
size = _sizeTween.begin = _sizeTween.end = constraints.smallest;
_state = RenderAnimatedSizeState.start;
child?.layout(constraints);
return;
} There was a problem hiding this comment.
unrelated to changes in this PR: I wonder if the existence of this subclass causes the AOT compiler to believe that Size is polymorphic and makes it slower than it could be.
There was a problem hiding this comment.
It would make the later text confusing ("this second render object" wouldn't be as obvious), so I've left it as object.
There was a problem hiding this comment.
fixed throughout the file
There was a problem hiding this comment.
I'd add `See [AnimatedCrossFade.defaultLayoutBuilder] for an example implementation'.
I also wonder if the keys should be uniquely generated GlobalKeys instead, thus allowing more interesting layouts than those based on multiple children. In fact, I wonder if we would need to pass the keys here at all if they are GlobalKeys?
There was a problem hiding this comment.
We want to avoid using global keys if at all possible. They're expensive.
You can always convert a LocalKey to a GlobalKey if you really need a global key on the receiving end.
There was a problem hiding this comment.
added your suggested text
Actually, i've just put in some sample code instead.
* Optimise AnimatedSize for the tight case. * Remove `default` from a switch statement over enum (so that analyzer will complain if we add enum values). * Adopt the Size since we use it after the child may have changed (which would throw normally). * AnimatedCrossFade.layoutBuilder
|
updated. will land on green, if it ever goes green. |
This reverts commit 1f08bda.
3 participants
defaultfrom a switch statement over enum (so that analyzer will complain if we add enum values).