Clean up _updateSelectionRects
#113425
Merged
Clean up _updateSelectionRects
#113425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
Contributor
Author
|
/cc @fbcouch if you'd like to review this pull request. |
LongCatIsLooong
force-pushed
the
selection-rects-caching
branch
from
a812a78 to
c1a72a7
Compare
LongCatIsLooong
force-pushed
the
selection-rects-caching
branch
from
c1a72a7 to
5087484
Compare
justinmc
approved these changes
Oct 14, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for cleaning this up. Great idea with the _ScribbleCacheKey class.
| ]); | ||
| log.clear(); | ||
|
|
||
| await tester.enterText(find.byType(EditableText), 'Text1👨👩👦'); |
Contributor
There was a problem hiding this comment.
Good call testing extended grapheme clusters 👍
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the cache invalidation logic. Also tried to avoid using
text.toPlainText. This is still very expensive to calculate/send, especially when the user is typing.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.