[tools]validation basic Xcode settings for build ipa #113412

hellohuanlin · 2022-10-13T22:14:22Z

This PR adds a few validation for flutter build ipa. There are more settings to be checked, but let's start with the following basic ones:

Example that fails the validation:

Example that passes the validation:

^ CC @leighajarett in case any feedbacks on the output above.

List which issues are fixed by this PR. You must list at least one issue.

#97730

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hellohuanlin · 2022-10-13T23:50:19Z

hmmm this passes on my local machine. i'm wondering if i need to bump the tools version or something so that CI uses the updated tools? @jmagman

jmagman · 2022-10-14T00:49:42Z

hmmm this passes on my local machine. i'm wondering if i need to bump the tools version or something so that CI uses the updated tools? @jmagman

Suspect you'll see something interesting in CI if you print the stderr. An integration test like this seems like a recipe for flakiness. I suggest instead mocking out the response from Xcode and adding these tests to commands.shard/hermetic/build_ipa_test.dart

flutter/packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

Lines 33 to 35 in 08e1729

    
           ...overrides, 
        
           'PRODUCT_BUNDLE_IDENTIFIER': 'io.flutter.someProject', 
        
           'DEVELOPMENT_TEAM': 'abc',

hellohuanlin · 2022-10-14T22:18:34Z

Found the error:

The error is: Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
════════════════════════════════════════════════════════════════════════════════
No valid code signing certificates were found
You can connect to your Apple Developer account by signing in with your Apple ID
in Xcode and create an iOS Development Certificate as well as a Provisioning 
Profile for your project by:
  1- Open the Flutter project's Xcode target with
       open ios/Runner.xcworkspace
  2- Select the 'Runner' project in the navigator then the 'Runner' target
     in the project settings
  3- Make sure a 'Development Team' is selected under Signing & Capabilities > Team. 
     You may need to:
         - Log in with your Apple ID in Xcode first
         - Ensure you have a valid unique Bundle ID
         - Register your device with your Apple Developer Account
         - Let Xcode automatically provision a profile for your app
  4- Build or run your project again
  5- Trust your newly created Development Certificate on your iOS device
     via Settings > General > Device Management > [your new certificate] > Trust

For more information, please visit:
  https://developer.apple.com/library/content/documentation/IDEs/Conceptual/
  AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html

Or run on an iOS simulator without code signing
════════════════════════════════════════════════════════════════════════════════
No development certificates available to code sign app for device deployment

I will delete this test then.

packages/flutter_tools/lib/src/commands/build_ios.dart

jmagman · 2022-10-14T22:48:48Z

packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

Interesting number choice... 🙂

packages/flutter_tools/lib/src/commands/build_ios.dart

jmagman

Can you update the description with the new output?

packages/flutter_tools/lib/src/ios/application_package.dart

jmagman · 2022-10-20T23:30:34Z

packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

@christopherfujino I hate to ask you religious questions but what's the recommended line length for the tool package? It's not 80, right?

ye ask and ye shall receiveth, https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#prefer-a-maximum-line-length-of-80-characters:

Aim for a maximum line length of roughly 80 characters, but prefer going over if breaking the line would make it less readable, or if it would make the line less consistent with other nearby lines. Prefer avoiding line breaks after assignment operators.

Of course the devil lies in "less readable"...

packages/flutter_tools/lib/src/commands/build_ios.dart

jmagman · 2022-10-20T23:35:08Z

packages/flutter_tools/lib/src/commands/build_ios.dart

The version number and build number aren't set in Xcode, but I guess it's better than the highest level https://docs.flutter.dev/deployment/ios ?

yeah neither is ideal. i'm fine either way.

What's your thought? @leighajarett?

Using the top level link has the benefit that it's more stable. It's very possible that we update the structure of the website and have a broken link.

I think I will just use https://docs.flutter.dev/deployment/ios then.

jmagman · 2022-10-26T20:27:17Z

packages/flutter_tools/lib/src/commands/build_ios.dart

Use a StringBuffer

cyanglaz

LGTM once other comments are addressed.

leighajarett · 2022-10-27T15:19:06Z

One thing that might be good to add is checking if the bundle identifier is using the reverse domain ("com.example") but we can also make that a separate issue to follow up on

jmagman · 2022-10-27T18:11:12Z

flutter_tools/lib/src/commands/build_ios.dart:145: trailing U+0020 space character

hellohuanlin · 2022-10-27T18:17:10Z

@leighajarett Good idea. I will add it in a follow up PR. Also commented in the github issue in case we forget.

cyanglaz · 2022-10-28T17:08:47Z

One thing that might be good to add is checking if the bundle identifier is using the reverse domain ("com.example") but we can also make that a separate issue to follow up on

The check does exist, https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/ios/mac.dart#L746-L753, might be good to add to the printBox.

…/flutter#113412)

This reverts commit e6300da.

…" (#114615) This reverts commit e6300da.

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

jmagman · 2022-11-03T17:05:36Z

@hellohuanlin this was reverted with #113412 to rule out a framework test failure, but it was unrelated. Can you re-land this?

* 4f19a9f [flutter_tools] Add support for compiling shaders to JSON bundle for web (flutter/flutter#114295) * f186e1b Roll pub packages (flutter/flutter#114363) * 0c7ee58 Make `Linux_android android_semantics_integration_test` flaky (flutter/flutter#114361) * 7ab2bf8 Delete flutter_migrate code (flutter/flutter#114253) * 0d26c51 Roll Flutter Engine from e432d6fc3a9b to ef4acbfe67ac (2 revisions) (flutter/flutter#114367) * af44c05 Roll Flutter Engine from ef4acbfe67ac to 9ba3de8f078d (1 revision) (flutter/flutter#114368) * 7979c87 Roll Flutter Engine from 9ba3de8f078d to ef45b5ac5b4b (1 revision) (flutter/flutter#114370) * c1a0846 Roll Flutter Engine from ef45b5ac5b4b to 96c0353790a2 (2 revisions) (flutter/flutter#114372) * a75c1ff Roll Flutter Engine from 96c0353790a2 to 1a8ba7c5521a (1 revision) (flutter/flutter#114375) * b20b7d9 Roll Flutter Engine from 1a8ba7c5521a to c16e2c08724c (1 revision) (flutter/flutter#114379) * 37b7234 Add `maybeOf` for all the cases where `of` returns nullable. (flutter/flutter#114120) * 6edbaa7 Roll Flutter Engine from c16e2c08724c to 034a2da497d9 (2 revisions) (flutter/flutter#114387) * 4851401 Roll Flutter Engine from 034a2da497d9 to f721db653dd1 (1 revision) (flutter/flutter#114389) * c2edb20 Added token files for badges and lists. (flutter/flutter#114382) * 0f1d0e3 🎨 Improve exceptions thrown by asset bundle (flutter/flutter#114313) * 3894a06 Minor code cleanup: remove redundant return (flutter/flutter#114290) * 0e98194 Add Material 3 support for BottomAppBar (flutter/flutter#106525) * 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

…#113412)" (flutter#114615) This reverts commit e6300da.

…flutter#114634)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 13, 2022

hellohuanlin requested review from cyanglaz and jmagman October 13, 2022 22:14

hellohuanlin force-pushed the tools_build_ipa_validate_basic_xcode_settings branch from 77b4054 to 6122f85 Compare October 13, 2022 23:14

jmagman reviewed Oct 14, 2022

View reviewed changes

cyanglaz reviewed Oct 17, 2022

View reviewed changes

packages/flutter_tools/lib/src/commands/build_ios.dart Outdated Show resolved Hide resolved

hellohuanlin force-pushed the tools_build_ipa_validate_basic_xcode_settings branch from f80bff1 to 26b6dff Compare October 20, 2022 22:37

hellohuanlin requested review from cyanglaz and jmagman October 20, 2022 22:41

hellohuanlin force-pushed the tools_build_ipa_validate_basic_xcode_settings branch from 26b6dff to 4b2a2fc Compare October 20, 2022 22:42

jmagman reviewed Oct 20, 2022

View reviewed changes

flutter-dashboard bot added the platform-ios iOS applications specifically label Oct 21, 2022

hellohuanlin requested a review from jmagman October 21, 2022 00:07

jmagman reviewed Oct 26, 2022

View reviewed changes

packages/flutter_tools/lib/src/commands/build_ios.dart Outdated

Copy link

Member

jmagman Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a StringBuffer

hellohuanlin reacted with thumbs up emoji

cyanglaz approved these changes Oct 26, 2022

View reviewed changes

hellohuanlin added 8 commits October 28, 2022 10:17

[tools]validation basic xcode settings for build ipa

22a45d5

added test by mocking xc result

bdc5348

delete the integration test

0aefd43

use plist instead of xctest

9771bdd

use fake plist parser

2d9eacf

update names

10c4532

address comments

08ea7c0

address a few comments

504bb3b

hellohuanlin added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 3, 2022

auto-submit bot merged commit e6300da into flutter:master Nov 3, 2022

This was referenced Nov 3, 2022

Roll Flutter from 37beffe2a98b to e6300da2c39f (63 revisions) flutter/packages#2776

Merged

Roll Flutter from 0e98194681fd to e6300da2c39f (46 revisions) flutter/plugins#6668

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2022

e6300da [tools]validation basic Xcode settings for build ipa (flutter…

18a3281

…/flutter#113412)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022

e6300da [tools]validation basic Xcode settings for build ipa (flutter…

dabe15a

…/flutter#113412)

zanderso added a commit that referenced this pull request Nov 3, 2022

Revert "[tools]validation basic Xcode settings for build ipa (#113412)"

774d10a

This reverts commit e6300da.

zanderso mentioned this pull request Nov 3, 2022

Revert "[tools]validation basic Xcode settings for build ipa" #114615

Merged

auto-submit bot mentioned this pull request Nov 3, 2022

Review request for Revert PR flutter/flutter#114615 #114616

Closed

auto-submit bot pushed a commit that referenced this pull request Nov 3, 2022

Revert "[tools]validation basic Xcode settings for build ipa (#113412)…

0943693

…" (#114615) This reverts commit e6300da.

hellohuanlin added a commit to hellohuanlin/flutter that referenced this pull request Nov 3, 2022

[tools]validation basic Xcode settings for build ipa (flutter#113412)

9bd327e

hellohuanlin mentioned this pull request Nov 3, 2022

[tools]reland validation basic Xcode settings for build ipa #114634

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Nov 3, 2022

[tools]validation basic Xcode settings for build ipa (#113412) (#114634)

8a9ddad

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

Revert "[tools]validation basic Xcode settings for build ipa (flutter…

e4e31ae

…#113412)" (flutter#114615) This reverts commit e6300da.

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

[tools]validation basic Xcode settings for build ipa (flutter#113412) (…

7a6f415

…flutter#114634)

jmagman added the blog label Jan 4, 2023

[tools]validation basic Xcode settings for build ipa #113412

[tools]validation basic Xcode settings for build ipa #113412

Uh oh!

Conversation

hellohuanlin commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin commented Oct 13, 2022

Uh oh!

jmagman commented Oct 14, 2022

Uh oh!

hellohuanlin commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Oct 21, 2022

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

leighajarett commented Oct 27, 2022

Uh oh!

jmagman commented Oct 27, 2022

Uh oh!

hellohuanlin commented Oct 27, 2022

Uh oh!

cyanglaz commented Oct 28, 2022

Uh oh!

jmagman commented Nov 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hellohuanlin commented Oct 13, 2022 •

edited

Loading

hellohuanlin Oct 21, 2022 •

edited

Loading