ignore PausePostRequest when reloading #11340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
B3rn475
approved these changes
Jul 21, 2017
Contributor
B3rn475
left a comment
B3rn475
left a comment
There was a problem hiding this comment.
I do confirm the missed reassemble and that the change fixes it.
LGTM
comment changes to kick the appveyor bot
goderbauer
added a commit
that referenced
this pull request
Jul 24, 2017
This reverts commit a92a627.
Contributor
|
This will make it difficult to set breakpoints in build methods. It will also expose the developer to an indeterminate state of which breakpoints are still active. |
Contributor
|
Due to dart-lang/sdk@ba5fe22 when editors request
Before dart-lang/sdk@ba5fe22 the isolate was resuming in both IntelliJ due to good timing was still able to reset breakpoints. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PausePostRequestevents when reloading (fix Hot reload button didn't perform hot reload #11336)This happens when a flutter_tools client - typically an IDE - requests a reload with the pause-after-reload flag set. This gives IDEs a chance to re-set breakpoints for the new scripts before the isolate starts executing again. In this case, we still want to request a reassemble of the app; the IDE client will resume the isolate, and without the reassemble, the hot reload is performed, but the app UI doesn't update.