Skip to content

Fix typo of PrimaryScrollController documentation #113361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 17, 2022
Merged

Fix typo of PrimaryScrollController documentation #113361

auto-submit merged 1 commit into from
Oct 17, 2022

Conversation

@mono0926
Copy link
Contributor

@mono0926 mono0926 commented Oct 13, 2022

Fix typo of PrimaryScrollController documentation.

Screen Shot 2022-10-13 at 15 25 26

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Oct 13, 2022
@TahaTesser TahaTesser self-requested a review October 13, 2022 18:25
TahaTesser
TahaTesser approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

goderbauer
goderbauer approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2022
@auto-submit auto-submit bot merged commit c84897c into flutter:master Oct 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
c84897c Fix typo of PrimaryScrollController documentation (flutter/fl…
f7f58c1 
…utter#113361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
c84897c Fix typo of PrimaryScrollController documentation (flutter/fl…
59d1473 
…utter#113361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
c84897c Fix typo of PrimaryScrollController documentation (flutter/fl…
68371dc 
…utter#113361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 19, 2022
@engine-flutter-autoroll
c84897c Fix typo of PrimaryScrollController documentation (flutter/fl…
5b3d621 
…utter#113361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mono0926 @goderbauer @TahaTesser