Always evaluate the finder in driver.waitFor*()
#11329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @yjbanov |
Contributor
|
test? |
Contributor
Author
|
No time in this PR - I'm half way out the door on vacation. I can wait until I get back if you like. |
Contributor
|
I can take it over and add a test. |
Contributor
Author
sg - thanks! |
Contributor
|
Should we close this PR in the meantime? |
Contributor
I'll pick it up right after I'm done cleaning up my other PRs. |
Contributor
|
But yeah, I'll have to rebase on top of @tvolkert's branch and open a new PR, so I'll have to close it anyway. |
Contributor
|
Closing this PR to get it off our review list, per comments above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11327