Skip to content

BufferLogger should log stacktrace #113240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 11, 2022
Merged

BufferLogger should log stacktrace #113240

auto-submit merged 2 commits into from
Oct 11, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 10, 2022

In BufferLogger simulate StdoutLogger printing the stacktrace

flutter/packages/flutter_tools/lib/src/base/logger.dart

Lines 466 to 469 in 492bfdd

writeToStdErr('$message\n');
if (stackTrace != null) {
writeToStdErr('$stackTrace\n');
}

This came up because I couldn't get this test to fail, realized it isn't validating anything since BufferLogger never prints the stackTrace.

flutter/packages/flutter_tools/test/commands.shard/hermetic/assemble_test.dart

Line 145 in 492bfdd

expect(testLogger.errorText, isNot(contains(stackTrace.toString())));

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 10, 2022
@jmagman jmagman self-assigned this Oct 10, 2022
Jasguerrero
Jasguerrero approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2022
@auto-submit auto-submit bot merged commit 8c8bb22 into flutter:master Oct 11, 2022
@jmagman jmagman deleted the logger-st branch October 11, 2022 20:17
This was referenced Oct 12, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)
a55d1a7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)
0d72e25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)
e5246be
stuartmorgan-g pushed a commit to flutter/plugins that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (#6567)
5f0a5f2 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (flutter#6567)
3077f34 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (flutter#6567)
81155f8 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @Jasguerrero