Do not call saveLayer for physical model layers whose bounds are simple rectangles #11324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le rectangles This is similar to an optimization done in PhysicalModelLayer::Paint in the engine
Member
Author
chinmaygarde
approved these changes
Jul 20, 2017
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Can we also add a TODO or create an issue that states that saveLayerss performed in the framework do not have the checkerboard pattern applied to them when the diagnostic option is enabled? It is easy to miss GPU bottlenecks because of this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to an optimization done in PhysicalModelLayer::Paint in the engine