Deprecate AnimatedListItemBuilder and AnimatedListRemovedItemBuilder
#113131
Conversation
flutter-dashboard
bot
added
d: api docs
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
force-pushed
the
deprecate_list_item_builder
branch
from
9c7878a to
3825134
Compare
There was a problem hiding this comment.
I think '//' is probably more appropriate here because as it stands we probably wouldn't want the exact text here as dartdocs (for example, it doesn't have a leading line that says what it is). As it stands, it's a comment (a good one, that explains what the example is about).
There was a problem hiding this comment.
I hear what you're saying, and I know what the style guide says, but consider these three things:
- if they are dartdoc comments, then the
[AnimatedRemovedItemBuilder]becomes a link that could be quite helpful to the user to click on in an IDE. Otherwise, it just looks like a piece of text that wishes it were a link. - This is in the examples, which aren't actually processed by dartdoc.
- It's on a private interface that, even if the examples were processed by dartdoc, would not show up in the output.
That said, I'm happy to either spruce up the comment so it's "good enough" to be a dartdoc comment, or remove the brackets and make it a "regular" comment that doesn't try to link to the symbols.
There was a problem hiding this comment.
I went with "sprucing it up"...
There was a problem hiding this comment.
might be more reassuring for people if this said "use the identical [...]"?
|
test-exempt: code refactor with no semantic change |
…in favor of AnimatedItemBuilder and AnimatedRemovedItemBuilder
gspencergoog
force-pushed
the
deprecate_list_item_builder
branch
2 times, most recently
from
f591c53 to
e8e8267
Compare
gspencergoog
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 113131, due to - The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
goderbauer
added
the
autosubmit
3 participants
Description
Deprecate
AnimatedListItemBuilderandAnimatedListRemovedItemBuilderin favor ofAnimatedItemBuilderandAnimatedRemovedItemBuilder, since they have the same signature, and just need a new, more appropriate, name.Tests