Don't relayout a Text if only its color changed. #11313
Conversation
| switch (_textPainter.text.compareTo(value)) { | ||
| case RenderComparison.identical: | ||
| case RenderComparison.metadata: | ||
| return; |
There was a problem hiding this comment.
Why a return here but a break below?
There was a problem hiding this comment.
accident of how i wrote the code, though i can justify it post-hoc: the "return" is an early return (nothing changed, bail out), whereas the other two branches are actually doing something. If we ever add something after the switch, I'd expect the identical/metadata cases to do nothing, but the other cases to do it.
|
LGTM. Nice use of enum.index. |
| /// For example, [layout] (index 3) implies [paint] (2). | ||
| enum RenderComparison { | ||
| /// The two objects are identical (meaning deeply equal, not necessarily | ||
| /// [identical]). |
There was a problem hiding this comment.
This just hyperlinks right back to this enum value (as seen on https://master-docs-flutter-io.firebaseapp.com/flutter/painting/RenderComparison-class.html)
There was a problem hiding this comment.
oops. I guess I want [dart:io.identical]. (cc @jcollins-g)
5 participants
No description provided.