Create one listener that merges the leading and trailing glow controllers and use it in each paint #11311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Hixie
reviewed
Jul 19, 2017
Contributor
There was a problem hiding this comment.
nit: this argument needs a type (i expect the analyzer will complain about this)
Contributor
|
|
…lers and use it in each paint If a new listener is created for each paint, then the leading and trailing controllers will accumulate and invoke a list of all those listeners
jason-simmons
force-pushed
the
overscroll_merge_listener
branch
from
c7a8461 to
fcd5c73
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new listener is created for each paint, then the leading and trailing
controllers will accumulate and invoke a list of all those listeners