Skip to content

Added Switch Animation for Material 3 #113090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 5 commits into from
Oct 12, 2022
Merged

Added Switch Animation for Material 3 #113090

QuncCccccc merged 5 commits into from
Oct 12, 2022

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Oct 7, 2022 •
edited by guidezpl
Loading

Part of: #91605

This PR is to add animation for M3 Switch.

Screen.Recording.2022-10-06.at.4.43.39.PM.mov

Slowed down for reference:

Screen.Recording.2022-10-06.at.4.45.29.PM.mov

Fixes #103536
Fixes #112026
Fixes #111663

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 7, 2022
@QuncCccccc QuncCccccc marked this pull request as ready for review October 7, 2022 18:13
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 7, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #113090 at sha 691ef38

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 7, 2022
HansMuller
HansMuller approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

darrenaustin
darrenaustin approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

dev/tools/gen_defaults/lib/switch_template.dart Outdated
double get trackWidth => ${tokens['md.comp.switch.track.width']};
// The thumb size at the middle of the track. Hand coded default based on the animation specs.
// https://direct.googleplex.com/#/spec/283220003&285130003
Copy link
Contributor

@darrenaustin darrenaustin Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a publicly available link? If not we probably shouldn't include it.

Copy link
Member

@guidezpl guidezpl Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

@QuncCccccc QuncCccccc Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Removed it. Thanks!

@guidezpl
Copy link
Member

guidezpl commented Oct 11, 2022

Great work!

@QuncCccccc QuncCccccc merged commit 91d8833 into flutter:master Oct 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
91d8833 Added Switch Animation for Material 3 (flutter/flutter#113090)
f8e6652
stuartmorgan-g pushed a commit to flutter/plugins that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (#6567)
5f0a5f2 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2022
@engine-flutter-autoroll
91d8833 Added Switch Animation for Material 3 (flutter/flutter#113090)
1c6e3ae
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (flutter#6567)
3077f34 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 4fed6aa to 91d8833 (13 revisions) (flutter#6567)
81155f8 
* 92b4305 Roll Flutter Engine from a5f44b8c08b6 to 7c4ad0b7d49e (1 revision) (flutter/flutter#113284)

* 95687eb Roll Plugins from cfbdcd0 to b175843 (6 revisions) (flutter/flutter#113287)

* 4cbeb9d Roll Flutter Engine from 7c4ad0b7d49e to 281152f8322d (1 revision) (flutter/flutter#113288)

* e1f3cff Roll Flutter Engine from 281152f8322d to c9f4e97abf68 (1 revision) (flutter/flutter#113291)

* 8c8bb22 BufferLogger should log stacktrace (flutter/flutter#113240)

* ee38dbd Roll Flutter Engine from c9f4e97abf68 to b783740a940f (1 revision) (flutter/flutter#113297)

* a84a258 Roll Flutter Engine from b783740a940f to 7979ffc80832 (1 revision) (flutter/flutter#113299)

* b2bba4a Roll Flutter Engine from 7979ffc80832 to 30d57deea8a6 (1 revision) (flutter/flutter#113304)

* 07e9293 Roll Flutter Engine from 30d57deea8a6 to bb0641278cd7 (1 revision) (flutter/flutter#113305)

* 096cd83 Roll Flutter Engine from bb0641278cd7 to c4da2d8903ce (1 revision) (flutter/flutter#113309)

* aab696c Roll Flutter Engine from c4da2d8903ce to 481f20168905 (1 revision) (flutter/flutter#113313)

* a5ee67e Roll Flutter Engine from 481f20168905 to ea64def17550 (1 revision) (flutter/flutter#113321)

* 91d8833 Added `Switch` Animation for Material 3 (flutter/flutter#113090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl left review comments

+2 more reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

4 participants

@QuncCccccc @guidezpl @darrenaustin @HansMuller