Send text selection rects to engine on iPhone #113048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
8 tasks
justinmc
approved these changes
Oct 6, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Support for selection rects was done exclusively for the Scribble feature, which is why there's that that early return for non-iPad devices. If we need selection rects for the floating cursor on iPhones, I see no reason not to send them. The performance impact should be negligible. CC @fbcouch who wrote the Scribble feature.
justinmc
added
the
autosubmit
This was referenced Oct 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 7, 2022
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
May 11, 2023
Floating cursor selection hasn't worked as we haven't been returning a real value for `caretRectForPosition:`. If we have the selection rectangles, we can do so. Fixes [#30476](flutter/flutter#30476) Requires selection rects to be turned on for iPhone (flutter/flutter#113048) writing and running engine tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get floating cursor selection to work on iPhone, we need the selection rects. Not sure what is the performance impact of this...
Needed to fix #30476
Related engine PR: flutter/engine#36643
Pre-launch Checklist
///).