Fix for Issue #112983 #112985
Merged
Fix for Issue #112983 #112985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
stuartmorgan-g
requested changes
Oct 6, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
It looks like you auto-formatted gradle_errors.dart; that will need to be reverted. (I'm not sure what the non-formatting change in that file is so I didn't do a full review.)
Contributor
Author
Auto formatting reverted, now it is just the required URL changes. |
stuartmorgan-g
approved these changes
Oct 7, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LTGM, thanks!
(I wish we could specify custom anchors so that minor rewordings of headings didn't break our links all the time.)
Contributor
Author
|
@stuartmorgan what is the process to land this PR? Tag with a merge on green tag? |
This was referenced Oct 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #112983
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.