Skip to content

Don't pass "null" to debugPrint. #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hixie merged 1 commit into from
Jul 19, 2017
Merged

Don't pass "null" to debugPrint. #11265

Hixie merged 1 commit into from
Jul 19, 2017

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 17, 2017

debugDumpLayerTree in particular was passing null in profile mode since debugLayer isn't available in profile mode.

@Hixie
Don't pass "null" to debugPrint.
f8875c7 
debugDumpLayerTree in particular was passing null in profile mode since debugLayer isn't available in profile mode.
goderbauer
goderbauer approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie merged commit 77b0c1d into flutter:master Jul 19, 2017
@Hixie Hixie deleted the debugPrintNull branch July 19, 2017 19:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @goderbauer @googlebot