Handle privatecommand messages that pass no data #112590
Conversation
flutter-dashboard
bot
added
a: text input
| _currentConnection!._client.performPrivateCommand( | ||
| firstArg['action'] as String, | ||
| firstArg['data'] as Map<String, dynamic>, | ||
| firstArg['data'] == null |
There was a problem hiding this comment.
nit: as Map<String, dynamic>?
There was a problem hiding this comment.
Oh duh, that's awesome that we can do that 👍
| /// which is the Android documentation for sendAppPrivateCommand, used to | ||
| /// send a command to the input method. | ||
| void performPrivateCommand(String action, Map<String, dynamic> data); | ||
| void performPrivateCommand(String action, Map<String, dynamic>? data); |
There was a problem hiding this comment.
This breaks internal tests I think?
There was a problem hiding this comment.
I'll try running the Google tests on this PR when it goes green. I thought about just creating an empty map if it's null and keeping this parameter the same non-nullable, but it felt dirty. I'll consider just migrating any breakages myself if it's not too crazy.
There was a problem hiding this comment.
I've requested Google tests but it's not showing up here... This never works for me. Maybe because the PR has no LGTM yet?
|
I LGTM'd earlier, google testing is now finished. |
|
Ah sorry you're right. Well it looks like there are tons of breaking changes from that. I should have assumed lots of people are implementing TextInputClient. I will use an empty Map to avoid the breaking change. |
justinmc
force-pushed
the
private-command-no-data
branch
from
94bb048 to
359d567
Compare
justinmc
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 112590, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@LongCatIsLooong @justinmc given the small size of the fix can it be cherry picked into stable or beta, as it's flooding crashlytics on old Android devices with each tap in a text field, related issue #113973 |
|
I agree with that, it would be a very low-risk cherry pick. @absar Can you create a new cherry pick request issue? (New Issue, then choose "Request a cherry-pick"). Tag me and @itsjustkevin please. |
…114461) Co-authored-by: Justin McCandless <[email protected]>
|
@justinmc I don't see this in beta branch, it should be cherry-picked there as well |
|
@absar Now it looks like it's released on beta. flutter/packages/flutter/lib/src/services/text_input.dart Lines 1880 to 1882 in 7592730 |
3 participants
Currently, if a
TextInputClient.performPrivateCommandplatform message is sent that has nodatakey, the framework will not know how to handle it and will throw an error. This PR properly handles this situation and eliminates the error.The engine purposely sends a map with no
datakey in situations where the data map isn't used (code).This PR allows receiving a null value and passing it through to onAppPrivateCommand.