Reland "Fix DraggableScrollableSheet rebuilding during drag" #112479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: scrolling
Contributor
|
Thanks for re-staging this @moffatman. I am just finishing fixing the customer code, we need that to land internally first before this can be merged. |
Piinks
approved these changes
Sep 28, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM! The customer is fixed, this can land now. :)
Merged
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Sep 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #111010 which was reverted in #112293
DraggableScrollableSheetwas rebuilding every time the size of the child changed, which meant every frame during a drag. Now it will only rebuild when it gets changed parameters from the parent widget.Also inadvertent fix to an exception thrown while rebuilding
DraggableScrollableSheetwith a new controller.Fixes #67219
Pre-launch Checklist
///).