Add a ScrollController parameter to NestedScrollView #11242
Conversation
HansMuller
force-pushed
the
nested_scrolling
branch
from
db1083a to
5d4ebdd
Compare
HansMuller
changed the title
HansMuller
changed the title
There was a problem hiding this comment.
can you add a test for this change?
There was a problem hiding this comment.
I've reverted this change. We'll probably revisit it in a future PR.
There was a problem hiding this comment.
It matches the similarly unqualified "updateParent()" method name.
There was a problem hiding this comment.
what is the purpose of this change?
There was a problem hiding this comment.
Future.wait doesn't return null, so Flutter will throw an error in the logs complaining about a type mismatch.
There was a problem hiding this comment.
Ah, I see. Is there a test that verifies this particular issue?
There was a problem hiding this comment.
The new tests are tripped up by this.
00:01 +3 ~1: - NestedScrollView with a ScrollController
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
type '_Future<List>' is not a subtype of type 'Future<Null>' of 'function result' where
_Future is from dart:async
List is from dart:core
Future is from dart:async
Null is from dart:core
There was a problem hiding this comment.
Just to be clear: if I reintroduce the error, the new tests catch it.
There was a problem hiding this comment.
the "first" here is a bug factory. For example, what if there's a scroll view prior to this one in the layout? it'll be the first scroll position in the default scroll controller, but it has no particular relationship with this scroll view.
HansMuller
force-pushed
the
nested_scrolling
branch
from
2d8c2b3 to
a09315f
Compare
|
I've eliminated the I added a TrackingScrollController class, which remembers the last scroll position that changed and reports its |
There was a problem hiding this comment.
Rather than returning 0.0 by default, return super.initialScrollOffset, and then have TrackingScrollController take an initialScrollOffset which it passes to the parent. That way, you can still set an initial scroll offset.
|
|
HansMuller
force-pushed
the
nested_scrolling
branch
from
9faab3f to
ad28044
Compare
4 participants
The NestedScrollView changes were contributed by @collinjackson
Fixes #10925
Fixes #11153