Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

I signed it!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

again

I believe to un-grump the CLA bot you'll need to force-push a new commit with the email address in the commit author field matching one that you've signed the CLA with. :(

Something like this:
https://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit

This needs detailed comprehensive tests.

@Hixie ok, will have a look into testing or did you mean manual testing? @eseidelGoogle I changed author in commit (my second commit in PR) but looks like I need to do PR again to pass CLA bot =(

This change should be applied to both floating/pinned and just pinned headers.

To clarify by testing I meant automated unit tests.

@nonameden Are you planning on doing the tests or should we take this PR over? (either way is fine, just trying to decide if we should leave the PR open in the meantime)

@Hixie sorry, it was busy week at my job, I was planning to do it next week.

Sounds good! No rush!

@nonameden I'm going to take over this patch and write a test for it. Thanks for your contribution!

Thank you @Hixie
I've played with test, but almost gave up with position detection for my slivers

Here the gist with test: https://gist.github.com/nonameden/5ac7b8c129e8ab9ede17fef2f8f0106b

Thanks, you can see what I came up with here: #11996
I found that I didn't need to change the scrollExtent line, can you elaborate (e.g. comment on that PR) about what doesn't work if that line isn't changed?
Also if there's anything else you think I should test don't hesitate to let me know on that PR.