-
Notifications
You must be signed in to change notification settings - Fork 29.7k
update engine version #112060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update engine version #112060
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
@gspencergoog seems like we are getting geometry errors here. Did we miss a cherry-pick? cc: @godofredoc |
|
|
Yes, it seems to be related, but I'm not sure what you've already included here. The engine roll you're moving to is earlier than the one that includes the asserts that are failing, so clearly you've got more than just what is in the engine at that ref, but if you don't have all four of these, then you'll have issues, either with the framework or the original bug reappearing. You will need all four, in this order: Or, you can make sure to include none of them. If you include none of them, then you may see rendering issues, since that's what it fixes (see #106849). |
|
Thanks @godofredoc and @gspencergoog, I added the framework cherry-picks. Hopefully these work out! |
godofredoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests succeeded!
No description provided.