Skip to content

Conversation

@itsjustkevin
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Sep 21, 2022
@itsjustkevin
Copy link
Contributor Author

@gspencergoog seems like we are getting geometry errors here. Did we miss a cherry-pick?

cc: @godofredoc

@godofredoc
Copy link
Contributor

@gspencergoog seems like we are getting geometry errors here. Did we miss a cherry-pick?

cc: @godofredoc

Are #111668 and #111515 already included in the branch?

@gspencergoog
Copy link
Contributor

Yes, it seems to be related, but I'm not sure what you've already included here. The engine roll you're moving to is earlier than the one that includes the asserts that are failing, so clearly you've got more than just what is in the engine at that ref, but if you don't have all four of these, then you'll have issues, either with the framework or the original bug reappearing.

You will need all four, in this order:
flutter/engine#36106 (0fce942)
#111515 (5f9ad01)
flutter/engine#36062 (0dceaab)
#111668 (c03eef4)

Or, you can make sure to include none of them. If you include none of them, then you may see rendering issues, since that's what it fixes (see #106849).

@itsjustkevin
Copy link
Contributor Author

Thanks @godofredoc and @gspencergoog, I added the framework cherry-picks. Hopefully these work out!

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests succeeded!

@itsjustkevin itsjustkevin merged commit 38955e7 into flutter:flutter-3.4-candidate.26 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants