Skip to content

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 20, 2022

Part 2 of a fix for #92673. In short, calling run app twice, the second with no content, and then resizing the window caused apps to hang. The initial fix should be landed here: flutter/engine#35409. The test for it is easier when the framework is available which is why this change is being landed in the flutter/flutter repo.

2 part fix to #92673

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 20, 2022
@a-wallen a-wallen force-pushed the macos_run_app_hangs branch 4 times, most recently from 127c157 to bdc3e23 Compare September 20, 2022 23:43
@a-wallen a-wallen changed the title [macOS] Fix hang after calling runApp twice and resizing. [macOS] Test hang after calling runApp twice and resizing. Sep 23, 2022
@a-wallen a-wallen closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant