Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 20, 2022

Reverts #111250

Fixes #111968

This caused a regression that made some portion of scrollables inaccessible via the scrollbar.
cc @TahaTesser

@Piinks Piinks requested a review from TahaTesser September 20, 2022 15:39
@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Sep 20, 2022
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 20, 2022

auto label is removed for flutter/flutter, pr: 111978, due to - The status or check suite Windows build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot merged commit 1b583a8 into master Sep 20, 2022
@auto-submit auto-submit bot deleted the revert-111250-drag_scrollbar_desktop branch September 20, 2022 16:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't scroll through whole viewport using ScrollBar.

3 participants