Skip to content

Conversation

@daniel-v
Copy link

@daniel-v daniel-v commented Sep 20, 2022

Allow passing --file-reporter option to test runner so that both machine and human readable output can be observed in a CI setting.

This has been supported in test runner for some time.

fixes #69425

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 20, 2022
@google-cla
Copy link

google-cla bot commented Sep 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Jasguerrero
Copy link
Contributor

Seems like you have real failing tests, can you address those?

@daniel-v
Copy link
Author

Seems like you have real failing tests, can you address those?

Of cource! For the moment, I changed the status of the PR to Draft to better indicate that it is still WIP (failing tests). I'll cc you when tests pass and thank you for your efforts.

@daniel-v daniel-v marked this pull request as draft September 30, 2022 08:36
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jan 17, 2023

@daniel-v Thanks for your contribution, this looks pretty valuable! Is this PR still on your radar?

@mateusfccp
Copy link
Contributor

I would love for this to be merged. If @daniel-v is not currently active, maybe I could proceed with this PR.

@daniel-v
Copy link
Author

@mateusfccp go right ahead! I'm not sure when I could get back to this PR. I'd be happy if you could continue working on it!

@mateusfccp
Copy link
Contributor

Rebased this patch in #120716 and fixed the tests. cc @Hixie

@Hixie
Copy link
Contributor

Hixie commented May 2, 2023

Thanks @daniel-v and @mateusfccp!

I'm going to close this PR (the code landed in #120716).

@Hixie Hixie closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter Test should support multiple reporters

4 participants