-
Notifications
You must be signed in to change notification settings - Fork 29.7k
allow passing --file-reporter option to test runner #111969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Seems like you have real failing tests, can you address those? |
Of cource! For the moment, I changed the status of the PR to Draft to better indicate that it is still WIP (failing tests). I'll cc you when tests pass and thank you for your efforts. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@daniel-v Thanks for your contribution, this looks pretty valuable! Is this PR still on your radar? |
|
I would love for this to be merged. If @daniel-v is not currently active, maybe I could proceed with this PR. |
|
@mateusfccp go right ahead! I'm not sure when I could get back to this PR. I'd be happy if you could continue working on it! |
|
Thanks @daniel-v and @mateusfccp! I'm going to close this PR (the code landed in #120716). |
Allow passing --file-reporter option to test runner so that both machine and human readable output can be observed in a CI setting.
This has been supported in test runner for some time.
fixes #69425
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.