Add slider customizations #11185
Add slider customizations #11185
Conversation
|
This will need tests; the |
|
What's the use case for not showing the thumb? |
| expect(sliderBox, paints..circle(color: theme.accentColor)); | ||
| await tester.pumpWidget(buildApp(customColor)); | ||
| expect(sliderBox, paints..rect(color: customColor)..rect(color: theme.unselectedWidgetColor)); | ||
| expect(sliderBox, paints..circle(color: customColor)); |
There was a problem hiding this comment.
you probably want some negative tests here too, verifying that there isn't a circle of the custom color when the custom color isn't set and that there isn't one of the accent color when the custom color is set.
|
One of our use cases of the slider doesn't have the thumb. However, after some discussion, we are removing that use case, so I will remove the |
|
Ok! |
|
|
|
This can land once the tree is green. |
|
Thank you very much for your contribution! |
|
Thank you @maryx ! |
|
@Hixie Thanks very much! Can you merge this in please? I don't have write access. |
|
Done! Thanks again! |
4 participants
When creating a Slider widget, a user can now customize: