Skip to content

Several cherrypicks for G3 roll #111787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 3 commits into from
Sep 16, 2022
Merged

Several cherrypicks for G3 roll #111787

godofredoc merged 3 commits into from
Sep 16, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Sep 16, 2022

CP: 5c94759
CP: d4cf505
CP: 857116d

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

godofredoc and others added 3 commits September 16, 2022 15:54
@godofredoc @engine-flutter-autoroll @Piinks
Revert "Update MaterialBanner to support Material 3" (#111612)
2540e26 
* Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

Co-authored-by: engine-flutter-autoroll <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Casey Hillers <[email protected]>
@godofredoc @engine-flutter-autoroll
@Piinks @XilaiZhang
Revert "Use semantics label for backbutton and closebutton for Androi… (
1a4836d 
#111636)

* Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

* Revert "Use semantics label for backbutton and closebutton for Android" (#111305)

Co-authored-by: engine-flutter-autoroll <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
Co-authored-by: Casey Hillers <[email protected]>
Co-authored-by: Xilai Zhang <[email protected]>
@engine-flutter-autoroll @godofredoc
Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#…
508a50c 
…111240)
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 16, 2022

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 16, 2022
@godofredoc godofredoc merged commit 1c8ae34 into flutter:flutter-3.4-candidate.25 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @fluttergithubbot @engine-flutter-autoroll