Revert "Single tap on the previous selection should toggle the toolbar on iOS…" #111662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
godofredoc
requested review from
Renzo-Olivares and
justinmc
and removed request for
Renzo-Olivares
Renzo-Olivares
approved these changes
Sep 15, 2022
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, i'll investigate what went wrong and try to reland.
godofredoc
added
the
autosubmit
godofredoc
added a commit
that referenced
this pull request
Sep 15, 2022
* Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) (#111533) Co-authored-by: engine-flutter-autoroll <[email protected]> * Revert Ballistic & Clamping simulation updates (#111535) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> * Revert "Update MaterialBanner to support Material 3" (#111612) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]> * Revert "Single tap on the previous selection should toggle the toolbar on iOS…" (#111662) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
This was referenced Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
…e toolbar on iOS…" (flutter/flutter#111662)
Renzo-Olivares
pushed a commit
to Renzo-Olivares/flutter
that referenced
this pull request
Sep 20, 2022
…e toolbar on iOS…" (flutter#111662)" This reverts commit 61db3bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #108913
Bug: #111660