Prepare the framework for having RRect assert on negative radii #111515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
gspencergoog
force-pushed
the
prepare_for_rrect_clamp
branch
from
db04f9b to
4629129
Compare
gspencergoog
changed the title
gspencergoog
force-pushed
the
prepare_for_rrect_clamp
branch
from
cad7592 to
93b2ba0
Compare
gspencergoog
force-pushed
the
prepare_for_rrect_clamp
branch
from
93b2ba0 to
5cff932
Compare
HansMuller
reviewed
Sep 14, 2022
| topRight: topRight, | ||
| bottomLeft: bottomLeft, | ||
| bottomRight: bottomRight, | ||
| topLeft: topLeft.clamp(minimum: Radius.zero), // ignore_clamp_double_lint |
Contributor
There was a problem hiding this comment.
Maybe create a RRect.clampCorners method? that applies one minimum/maximum radius to all four corners?
Contributor
Author
There was a problem hiding this comment.
Sure, I could, but really this won't be a problem once the RRect doesn't allow negative values anymore (which will happen shortly). I mean, sure, clamping to something other that zero might also be important, but it's not something that people have requested.
EDIT: Actually, these will remain in place. Can I maybe wait to add RRect.clampCorners? If it's not required, I won't need to make a round trip through the engine in order to land this PR.
gspencergoog
requested review from
goderbauer
and removed request for
darrenaustin
goderbauer
reviewed
Sep 14, 2022
| topLeft: topLeft.clamp(minimum: Radius.zero), // ignore_clamp_double_lint | ||
| topRight: topRight.clamp(minimum: Radius.zero), // ignore_clamp_double_lint | ||
| bottomLeft: bottomLeft.clamp(minimum: Radius.zero), // ignore_clamp_double_lint | ||
| bottomRight: bottomRight.clamp(minimum: Radius.zero), // ignore_clamp_double_lint |
Member
There was a problem hiding this comment.
Are these ignores temporary? If so, maybe add a TODO?
Member
There was a problem hiding this comment.
Also, why are these ignores needed in the first place? You aren't even calling clamp on double here.
Is the ignore_clamp_double_lint triggering too broadly and needs some tightening?
Contributor
Author
There was a problem hiding this comment.
Yes, I wondered the same thing, but there are reasons why we can't narrow it.
See here.
goderbauer
approved these changes
Sep 14, 2022
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM with added doc comment
gspencergoog
added
the
autosubmit
This was referenced Sep 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 15, 2022
itsjustkevin
added a commit
that referenced
this pull request
Sep 21, 2022
* update engine version * Prepare the framework for having RRect assert on negative radii (#111515) * Remove no-longer-needed clamping of RRect radii (#111668) Co-authored-by: Greg Spencer <[email protected]>
itsjustkevin
added a commit
that referenced
this pull request
Sep 22, 2022
* update engine version * Prepare the framework for having RRect assert on negative radii (#111515) * Remove no-longer-needed clamping of RRect radii (#111668) * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]> Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prepares the framework for flutter/engine#36062 to roll into the framework, which will clamp rounded rect (
RRect) corner radii to a min of zero when deflating, and assert that radii are not negative.In order for that to roll in cleanly, we need to change the framework so that it does its own clamping when deflating rounded rects. Once the engine change rolls in, we can remove the extra clamping.
Related Issues
Tests