Skip to content

Add onFocusChange property for ListTile widget - #111498

Merged
HansMuller merged 12 commits into
flutter:masterfrom
M97Chahboun:add_onFocusChange_property_for_ListTile_widget
Nov 29, 2022
Merged

HansMuller merged 12 commits into
flutter:masterfrom
M97Chahboun:add_onFocusChange_property_for_ListTile_widget

Conversation

@M97Chahboun

@M97Chahboun M97Chahboun commented Sep 13, 2022 •

Copy link
Copy Markdown
Contributor

Fixes #99608

Adds a onFocusChange property to ListTile widget,

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Sep 13, 2022
@M97Chahboun

Copy link
Copy Markdown
Contributor Author

@HansMuller Please check this PR when you are available.

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just asking for the same change to be applied to the other ListTile widgets.

@M97Chahboun M97Chahboun changed the title Add on focusChange property for list tile widget Add onFocusChange property for ListTile widget Nov 25, 2022

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog - do the extra callbacks look OK to you?

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Yes, looks good to me. (I mean, it's unfortunate that it isn't called onFocusChanged everywhere, but that's the not the fault of this PR, and there's no point in being inconsistent.)

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2022
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2022
@auto-submit

auto-submit Bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 111498, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submit Bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 111498, due to Validations Fail.

@gspencergoog

Copy link
Copy Markdown
Contributor

@HansMuller Can you please also mark this as "approved" in GitHub so that the bot is happy?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] add onFocusChange in ListTile

3 participants