Skip to content

Remove Apple Silicon workarounds from plugin lint test#111432

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
jmagman:arm-lint
Sep 20, 2022
Merged

Remove Apple Silicon workarounds from plugin lint test#111432
auto-submit[bot] merged 3 commits into
flutter:masterfrom
jmagman:arm-lint

Conversation

@jmagman

@jmagman jmagman commented Sep 13, 2022

Copy link
Copy Markdown
Member

ARM Macs are now supported, as well as the arm64 iOS simulator. Remove workarounds from #77028

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests platform-ios iOS applications specifically platform-macos Building on or for macOS specifically labels Sep 13, 2022
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 13, 2022
@jmagman

jmagman commented Sep 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Test run:
https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/18212

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit
auto-submit Bot merged commit 60c6cbf into flutter:master Sep 20, 2022
@jmagman
jmagman deleted the arm-lint branch September 20, 2022 21:13
This was referenced Sep 21, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
60c6cbf Remove Apple Silicon workarounds from plugin lint test (flutt…
bda588f 
…er/flutter#111432)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
60c6cbf Remove Apple Silicon workarounds from plugin lint test (flutt…
45bb1b0 
…er/flutter#111432)
@jmagman jmagman mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes
@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically platform-macos Building on or for macOS specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @hellohuanlin