Skip to content

[macOS] Add flutter_view example. #111326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 17 commits into from
Sep 14, 2022
Merged

[macOS] Add flutter_view example. #111326

auto-submit merged 17 commits into from
Sep 14, 2022

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 10, 2022 •
edited
Loading

The flutter_view example was unimplemented and benchmark tests that ran the example as a part of a task could not depend on it. This PR implements the flutter_view example for the purpose of

  1. enriching the documentation
  2. bringing up more tests
Screen.Recording.2022-09-09.at.5.56.16.PM.mov

fixes #110538
fixes #110085
fixes #42281
fixes #109633

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 10, 2022
@a-wallen a-wallen marked this pull request as ready for review September 10, 2022 06:27
yaakovschectman
yaakovschectman approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but take that with a grain of salt as I am not familiar with swift or XCode

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 12, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@a-wallen a-wallen force-pushed the macos_flutter_view_example branch 5 times, most recently from fb77924 to c302b31 Compare September 13, 2022 16:56
loic-sharma
loic-sharma reviewed Sep 13, 2022
View reviewed changes
loic-sharma
loic-sharma reviewed Sep 13, 2022
View reviewed changes
loic-sharma
loic-sharma reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snazzy app! LGTM, but my Swift is very weak 😅

@a-wallen a-wallen force-pushed the macos_flutter_view_example branch 6 times, most recently from 07c2c64 to 20ee036 Compare September 14, 2022 06:51
@a-wallen a-wallen force-pushed the macos_flutter_view_example branch 4 times, most recently from 5581065 to 0f34104 Compare September 14, 2022 21:07
cbracken
cbracken approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-lgtm modulo comments!

@a-wallen a-wallen force-pushed the macos_flutter_view_example branch from 0f34104 to dfb8e6d Compare September 14, 2022 22:21
@a-wallen
Copy link
Contributor Author

a-wallen commented Sep 14, 2022

Dropping android build failure fix and widget tests in favor of perf tests. Integration tests will be available on https://github.com/a-wallen/flutter/tree/macos_flutter_view_example_with_integration

@a-wallen a-wallen force-pushed the macos_flutter_view_example branch from dfb8e6d to 8df93e8 Compare September 14, 2022 22:30
@a-wallen a-wallen requested a review from keyonghan as a code owner September 14, 2022 22:35
@a-wallen a-wallen mentioned this pull request Sep 14, 2022
Closed
8 tasks
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2022
@auto-submit auto-submit bot merged commit 96b49aa into flutter:master Sep 14, 2022
@a-wallen a-wallen deleted the macos_flutter_view_example branch September 14, 2022 23:44
This was referenced Sep 15, 2022
Merged
Merged
This was referenced Sep 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
96b49aa [macOS] Add flutter_view example. (flutter/flutter#111326)
a937af6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
96b49aa [macOS] Add flutter_view example. (flutter/flutter#111326)
673797f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

@cbracken cbracken cbracken approved these changes

@jmagman jmagman Awaiting requested review from jmagman

@keyonghan keyonghan Awaiting requested review from keyonghan

+1 more reviewer

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

4 participants

@a-wallen @cbracken @loic-sharma @yaakovschectman