Revert "Update MaterialBanner to support Material 3"
#111288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8fdb83.
flutter-dashboard
bot
added
f: material design
XilaiZhang
approved these changes
Sep 9, 2022
hannah-hyj
approved these changes
Sep 9, 2022
8 tasks
CaseyHillers
added
the
autosubmit
This was referenced Sep 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
godofredoc
added a commit
that referenced
this pull request
Sep 14, 2022
* Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]>
godofredoc
added a commit
that referenced
this pull request
Sep 15, 2022
#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
godofredoc
added a commit
that referenced
this pull request
Sep 15, 2022
* Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) (#111533) Co-authored-by: engine-flutter-autoroll <[email protected]> * Revert Ballistic & Clamping simulation updates (#111535) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> * Revert "Update MaterialBanner to support Material 3" (#111612) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]> * Revert "Single tap on the previous selection should toggle the toolbar on iOS…" (#111662) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
godofredoc
added a commit
that referenced
this pull request
Sep 16, 2022
* Revert "Update MaterialBanner to support Material 3" (#111612) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]> * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
itsjustkevin
added a commit
that referenced
this pull request
Sep 22, 2022
* update engine version * Prepare the framework for having RRect assert on negative radii (#111515) * Remove no-longer-needed clamping of RRect radii (#111668) * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e133ef51 to 6610f3f2a9fb (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]> Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #105957
b/245951764
This broke a few specs internally at Google relating to Material. Feedback was followed up in the original PR with the changes that should be made.